81895 - New Bookmark/Folder/Separator should be disabled in Search Results Window

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Chris Lyon]

Using build 2001051920 on Win2K

Steps to Resproduce:
1. Open Manage Bookmarks Window
2. Search Bookmarks
3. In the Search Results Window, create a new bookmark, folder and separator

Results:
Bookmark: nothing happens
Folder and separator:
Error: [Exception... "Component returned failure code: 0x80004005 
(NS_ERROR_FAILURE) [nsIRDFDataSource.DoCommand]"  nsresult: "0x80004005 
(NS_ERROR_FAILURE)"  location: "JS frame :: 
chrome://communicator/content/bookmarks/bookmarksOverlay.js :: anonymous :: 
line 763"  data: no]
Source File: chrome://communicator/content/bookmarks/bookmarksOverlay.js
Line: 763

Reproducible:
Always

Expected Results:
These options should be disabled in the Search Results Window.

Comment 1

[Chris Lyon]

Sorry about that,
creating a New Bookmark works.  It adds the new bookmark to the default 
location in the bookmark list. However there is no feedback from the Search 
Results Window.

Comment 2

[doctor__j]

It doesn't make sense to create a Bookmark separator in a bookmark search result
window.  Creating a bookmark folder or a bookmark itself is justifiable.

Comment 3

[Chris Lyon]

The reason I think it should be disabled is because it's not clear where these 
new bookmarks and folders should be created.  Should they be created in the 
default location, or in the same folder as the search results?  

Either way, there is currently no feedback in the Search Results Window, making 
it confusing for users.

Comment 4

[doctor__j]

> ... it's not clear where these new bookmarks and folders should be created.

I suggest to create these new things at the very end of the bookmark tree.

> Either way, there is currently no feedback in the Search Results Window,
> making it confusing for users.

Because the bookmark search is not supposed to be a monitoring for new items in
realtime (right, Ben?), so the newly created bookmark (whether it *matches* the
searching criteria or NOT) will not be shown in the search result window.  At
least I think in this way.  Don't know how other users might interpret that.

Comment 5

[Chris Lyon]

>Because the bookmark search is not supposed to be a monitoring for new items in
>realtime

I totally agree.  That's why I don't think this is an appropriate place to 
create new items in the bookmark list.

Look at the Find utility in Windows Explorer, for example.  You cannot create 
folders or copy files into a search results window.  I think Mozilla should 
behave the same way.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter 
email notifications caused by this by searching for 'ilikegoats'.

Comment 7

[Peter Trudelle]

mass reassign of pchen bookmark bugs to ben

Comment 8

[xyzzy]

*** Bug 118395 has been marked as a duplicate of this bug. ***

Comment 9

[Peter Trudelle]

IMO, this whole window is far too heavyweight, containing much excess UI,
slowing down the task of finding things, and making it difficult to do what I
want after I've found them. 'Find' should find things where they are, like
elsewhere in this and other products.  I'm not sure why there is any real need
for a Search Results window at all.  cc marlon for UE input.

Comment 10

[Peter Trudelle]

nsbeta1- per nav triage team.

Comment 11

[Pierre Chanial]

taking

Comment 12

[Torben]

Should be fixed with bug 160019, please reopen if I am mistaken.