Closed Bug 82306 Opened 23 years ago Closed 23 years ago

JS URI method impurity

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.1

People

(Reporter: brendan, Assigned: brendan)

References

(
URL
)

Details

(Keywords: js1.5)

Attachments

(3 files)

testcase
221 bytes, patch
Details | Diff | Splinter Review
proposed fix
4.89 KB, patch
Details | Diff | Splinter Review
real proposed fix -- IGNORE LAST PATCH (sorry!)
1003 bytes, patch
Details | Diff | Splinter Review 
Testcase attachment coming up, courtesy Mike Epstein <epstein@tellme.com>.

/be
Severity: normal → critical
Status: NEW → ASSIGNED
Keywords: js1.5, mozilla0.9.1
Priority: -- → P1
Target Milestone: --- → mozilla0.9.1
Attached patch testcase — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        proposed fix
        — 
          — Splinter Review
      

    


  

    
    

    
  
Looking for last minute code buddies for 0.9.1.  This one is easy: truncating
divide was just wrong when checking whether we needed to reallocate!

/be

    
    

    
  
D'oh!  That patch has other cruft in it.  One sec...

/be

    
    

    
  
sr=scc

    
    

    
  
r/sr=jband 

[or should I be using someone else's name?]

I'm still wondering about brendan's checkin comment...
  Warning abatement (r=polarbear, sr=lumpy).


    
    

    
  
r=rginda on the new patch.

    
    

    
  
Fixed, thanks to speedy review pals.

/be
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
Mike's testcase added to JS testsuite:

               js/tests/js1_5/Regress/regress-82306.js

    
    

    
  
Verified Fixed - testcase passes in debug/optimized JS shells on WinNT, Linux.
Status: RESOLVED → VERIFIED

    
    

    
  
*** Bug 81033 has been marked as a duplicate of this bug. ***

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: