82457 - Dragging items on personal toolbar can lose bookmarks

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Simon Fraser [no longer active]]

It's possible to drag items around on the personal toolbar such that you lose 
them. Here's how:

1. Have several items on your PT
2. Drag the 2nd item to the left, and drop it on top of the 'Bookmarks' item. 
You'll get these assertions:

###!!! ASSERTION: illegal value: 'aIndex >= 1', file nsRDFContainer.cpp, line 283
###!!! ASSERTION: unable to add bookmark to container: 'NS_SUCCEEDED(rv)', file 
nsBookmarksService.cpp, line 1473

3. Note that the item you dragged disappeared from its original location, and has 
now disappeared. Bad bad bad. This stuff needs to be paranoid about data loss

Comment 1

[Joe Hewitt (gone)]

Sadly, I noticed this problem myself the day after I landed the last round of 
personal toolbar dnd fixes.

Fixing this one is fairly straightforward.  Maybe I can get it in for 0.9.1

Comment 2

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 3

[Joe Hewitt (gone)]

This patch addresses three cases in which bookmarks will be lost when dragged
around on the personal toolbar:

1. when a bookmark is dragged onto itself
2. when a bookmark is dragged onto a "fake" bookmark, like "Bookmarks" or "Shop"
3. when a bookmark is dragged onto an expanded folder, like an ftp or file url
bookmark

Comment 4

[Joe Hewitt (gone)]

Attachment: patch using blake's suggestion to add negative drag feedback as well

Comment 5

[Blake Ross]

Don't return a value and sr=blake.

Comment 6

[Joe Hewitt (gone)]

Attachment: one more patch

Comment 7

[Simon Fraser [no longer active]]

r=sfraser

Comment 8

[selmer (gone)]

Approved when sr= is reached.

Comment 9

[Blake Ross]

I pointed out the change that hewitt made in the new patch...my sr still stands.

Comment 10

[R.K.Aa.]

Is bug 83008 a dup?

Comment 11

[doctor__j]

*** Bug 83008 has been marked as a duplicate of this bug. ***

Comment 12

[Christopher Blizzard (:blizzard)]

a=blizzard for 0.9.1

Comment 13

[Joe Hewitt (gone)]

fixed

Comment 14

[Claudius Gayle]

*** Bug 83371 has been marked as a duplicate of this bug. ***

Comment 15

[Claudius Gayle]

VERIFIED Fixed