829428 - Assertion failure: "AncestorHasDirAuto set on node but not its children" with non-HTML element

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase (asserts fatally when loaded)

Assertion failure: !aElement->AncestorHasDirAuto() || child->AncestorHasDirAuto() (AncestorHasDirAuto set on node but not its children), at content/base/src/DirectionalityUtils.cpp:688

Comment 1

[Simon Montagu :smontagu]

Attachment: Make DoesNotParticipateInAutoDirection return true for non-HTML elements; and make WalkDescendantsSetDirAuto consistent with SetDirOnBind

Comment 2

[Simon Montagu :smontagu]

Attachment: The testcase for checkin

Comment 3

[(no longer active)]

Comment on attachment 701786 [details] [diff] [review]
The testcase for checkin

rs=me

Comment 4

[Simon Montagu :smontagu]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af13d04d949e
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d19aad2dab3

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/af13d04d949e
https://hg.mozilla.org/mozilla-central/rev/5d19aad2dab3

Comment 6

[Simon Montagu :smontagu]

Comment on attachment 701785 [details] [diff] [review]
Make DoesNotParticipateInAutoDirection return true for non-HTML elements; and make WalkDescendantsSetDirAuto consistent with SetDirOnBind

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 548206 or one of it's follow-ups
User impact if declined: possible incorrect resolution of elements with dir=auto
Testing completed (on m-c, etc.): Baked on m-c since 2013-01-15
Risk to taking this patch (and alternatives if risky): None known
String or UUID changes made by this patch: None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b615064c9928
https://hg.mozilla.org/releases/mozilla-aurora/rev/10e995513c11

Comment 9

[Dave Townsend [:mossop]]

Backed out as this set the tree on fire.

https://hg.mozilla.org/releases/mozilla-aurora/rev/edd364a9f0d5

Comment 10

[Simon Montagu :smontagu]

Attachment: The patch merged to Aurora

Yeah, Aurora doesn't have bug 828166 so the trunk patch doesn't build there.

Comment 11

[Simon Montagu :smontagu]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5582b3b1bafa
https://hg.mozilla.org/releases/mozilla-aurora/rev/a728a1f234a0

Comment 12

[Cédric Valmary]

Hi !
Can occitan language be added on :
http://hg.mozilla.org/releases/mozilla-aurora/file/tip/browser/locales/shipped-locales
and
http://www.mozilla.org/en-US/firefox/all-aurora.html

Files are availables on http://mozilla.locamotion.org/oc/firefox/

Best regards

Comment 13

[Simon Montagu :smontagu]

Comment 12 has nothing to do with this bug.

Comment 14

[Tiziana Sellitto [:tiziana]]

Issue reproducible with the debug build from 2013-01-10. (assertion failure + Firefox crash)

Verified fixed with Firefox 21 latest debug build, on Mac OSX 10.8.3 (no assertion failure + no Firefox crash)

Build ID: 20130426142004