83206 - Add close button to CRL view

Status: RESOLVED DUPLICATE of bug 343395

(Core Graveyard :: Security: UI, defect, P3)

Description

[Steve Parkinson]

The CRL view window needs to have a close button. Currently the only button is 
'delete'.

In case anyone needs to verify the bug, to find the CRL view window:

Edit->preferences
Privacy and Security
Validation
Manage CRL's.

Comment 1

[Bob Lord]

-> 2.0, P3

Comment 2

[Bob Lord]

*** Bug 83319 has been marked as a duplicate of this bug. ***

Comment 3

[John Unruh]

*** Bug 84675 has been marked as a duplicate of this bug. ***

Comment 4

[Stephen Walker]

Attachment: patch

Comment 5

[Daniel Brooks [:db48x]]

Shouldn't the close button go in the righthand corner? You could just add a
spring...

Also, what's the difference between a <button class="dialog push"/> and a
<button class="normal"/>?

Comment 6

[Daniel Brooks [:db48x]]

Ok, since none of those classes mean anything, I say you remove them.

As for the buttons, it seems like most of the psm dialogs have Ok/Cancel, and
they're split about 50/50 between right and left corners. In that case, either
one is fine with me.

r=db48x

Comment 7

[Stephen Walker]

Attachment: updated patch - removed class code for buttons

Comment 8

[Stephen Walker]

cc'ing blake for sr=

Comment 9

[Blake Ross]

No, no Close button.  cc'ing Matthew about this. Again.

Comment 10

[Steve Parkinson]

Blake, what are you saying?  Is a close button is against some guideline?

Comment 11

[timeless]

yes, it's against mpt's guidelines. mind you i don't think he's posted them 
anywhere, but that's ok you can take our word for it being against mpt's 
guidelines.

Comment 12

[Daniel Brooks [:db48x]]

I think that since it's already got a Help button, there's no harm in adding a
close button as well. 

Comment 13

[Mike Schiraldi]

I don't see a Help button in the Manage CRLs list. 

Still, just to throw in my two cents, every other popup in the Preferences
section has a button that will close it, be it Ok, Cancel, or Close.

Prefs itself:            Ok, Cancel
All the "Choose File"s:  Open, Cancel
Languages->Add:          Ok, Cancel
Helper Apps->New Type:   Ok, Cancel
View Stored Cookies:     Ok, Cancel
Cookies->More Info:      Close       (because there's nothing to edit)
View Image Perms:        Ok, Cancel
View Stored Form Data:   Ok, Cancel
Forms->View Sites:       Ok, Cancel
View Stored Passwords:   Ok, Cancel
Edit Ciphers:            Ok, Cancel
Manage Certificates:     Close
Manage Security Devices: Ok
Manage CRLs:             <nothing>

I can abort my changes in most prefs popups by clicking cancel. So why are
Manage Certificates/Security Devices/CRLs different? Why shouldn't they have
"Ok" and "Cancel" buttons like everything else?

No need to defend your actions if you still don't agree with me, i just wanted
to state my case, go, and leave it up to you guys to decide. I don't know what
the guidelines say, but since your users won't have read them, it will look like
a mistake to them and a lack of attention to detail.

Comment 14

[Stephane Saux]

Mass reassigning target to 2.1

Comment 15

[Matthew T (active 1999-2002)]

WORKSFORME, build 2001070308: the `Manage CRLs' (pardon?) window already has a 
close button, in its title bar. The `Delete' button should either be to the 
right of the tree, or replaced by a `File' > `Delete' menu item, but that 
should be filed as a separate bug.

> So why are Manage Certificates/Security Devices/CRLs different? Why shouldn't
> they have "Ok" and "Cancel" buttons like everything else?

If you want to turn this window into a dialog, giving it `OK' and `Cancel' 
buttons such that changes can be undone by clicking `Cancel', you should file 
that as a separate RFE.

For future reference, you shouldn't rely on anything in the Privacy & Security 
area in Mozilla as being an example of decent UI -- not for another few months, 
at least. For example, Cookies->More Info and Manage Certificates having 
`Close' push buttons are both bugs.

Comment 16

[John Unruh]

Reopening for review. I would like to see a close button.

Comment 17

[Bob Lord]

I don't see a need for another close box.  The one in the title bar should work
fine. If that's not true on all platforms, please post here and reopen the bug.

Comment 18

[John Unruh]

Verified worksforme.

Comment 19

[Kai Engert (:KaiE:)]

From bug 96586:

"The Cert Manager UI can effectively lock up Mac OSX 10.0 without a close button."

Comment 20

[Charles Goyard]

Hi,

Some window manager, such as Ion (which I use), don't offer close button on
title bar, because of a different concept from usual WM.

To close the Certs window, I have to kill the entire browser application, which
you may admit, is not very practical.

Comment 21

[Kai Engert (:KaiE:)]

I agree a close button makes sense, then.
Reopening.

Recently Scott MacGregor made a change to the security manager dialogs that turn
them into dialogs, should be contained in the nightly builds heading to 1.5. I
wonder if that possibly already fixed it.

Comment 22

[Kai Engert (:KaiE:)]

-> me

Comment 23

[Alex Hirzel]

*** Bug 96586 has been marked as a duplicate of this bug. ***

Comment 24

[Olivier Cahagne]

*** Bug 240797 has been marked as a duplicate of this bug. ***

Comment 25

[Sten Carlsen]

I would be happy to have ANY possibility to close the window without closing the
whole app.

On MAC OSX 10.2.8 There are always three buttons in the upper left hand corner;
one of these is the close button. In this particular window it is disabled so
only minimize works. Would it be possible to just enable this close button? OR
provide any other means to close the window.

Comment 26

[Stefan [:stefanh]]

*** Bug 276026 has been marked as a duplicate of this bug. ***

Comment 27

[Stefan [:stefanh]]

Attachment: Screenshot of CRL manager dialog on Mac OS X

Kai, any status on this? The CRL Manager window is impossible to close on Mac
OS X. Is there any way to enable the close button in the upper left corner?

Comment 28

[[e-mail]]

Stefan, try adding "close" to the list of window features in the window.open
call at the end of pref-validation.js (which I guess is the right file).

Comment 29

[Stefan [:stefanh]]

(In reply to comment #28)
> Stefan, try adding "close" to the list of window features in the window.open
> call at the end of pref-validation.js (which I guess is the right file).

Removing the window feature 'dialog' enables the close-button at the upper left
corner...

Compare the Firefox js at
http://lxr.mozilla.org/seamonkey/source/browser/components/prefwindow/content/pref-advanced.js#147
with Seamonkey:
http://lxr.mozilla.org/seamonkey/source/security/manager/pki/resources/content/pref-validation.js#105

I wouldn't mind removing the 'dialog'... I guess it could be removed from other
window.open calls as well.

Comment 30

[[e-mail]]

Removing the dialog style sounds good to me.

Comment 31

[Stefan [:stefanh]]

Attachment: Removes dialog style and adds a close button

This patch will:

1) Remove the dialog style from the window.open call in pref-validation.js.
This means that a user now can close, minimize and maximize the window with the
buttons in the titlebar on all(?) platforms.

2) Fix a new title for the window ("CRL Manager")

3) Add a "Close button" to the window

The last one is more of a proposal (even if that's what this bug is about).
Here's some arguments/problems:

This is the only window that doesn't have a "Close" or "OK" button, so in the
name of consistency there should be a button. The question is if it should be a
"Close" or "OK" button.

A "Close" button will be in line with Password mgr, Form mgr: sites, Cookie
mgr, and Image mgr in Mozilla. However, a close button will not be in line with
any window in Firefox (that uses the same crlmanager as Mozilla) -- the "OK"
button is used in all the manager windows.

If you can close the window from the titlebar, a "Close" button sounds more
logical to me. If you have an "OK" button, one might get the impression that
closing the window from the titlebar will undo the changes.

On the other hand, If you can close the window from the titlebar -- do we
really need a Close/OK button?

Thoughts?

Comment 32

[Stefan [:stefanh]]

Attachment: correct version

Sigh, too tired -- forgot to save the file before I attached it :(

Comment 33

[Stefan [:stefanh]]

Attachment: New patch that only removes the dialog feature (checked in)

OK, I sort of realize that my patch is probably an overkill. So, here's a patch
that just removes the window.open feature 'dialog'. That will make the window
have minimize/maximize/close buttons in the titlebar.

Comment 34

[Stefan [:stefanh]]

Requesting blocking 1.8b. Mac users haven't been able to close the window for
ages...

peterv, have you had any time to look at the patch?

Comment 35

[Stefan [:stefanh]]

Comment on attachment 171370 [details] [diff] [review]
New patch that only removes the dialog feature (checked in)

Thanks Peter :)

Neil, can you check in the patch please?

Comment 36

[Kai Engert (:KaiE:)]

changing obsolete psm* target to --- (unspecified)

Comment 37

[Oleg Titov]

still there is no Close button in SeaMonkey 1.0.7