83241 - file:// needs decoder to sniff file types

Status: VERIFIED FIXED

(Core :: Networking: File, defect, P2)

Description

[Scott MacGregor]

Currently if you attempt to load an image in a file that doesn't have an
extension, 6.x throws the unknown content handler. 

i.e. if I have a .jpg in a local file called "test". We won't display the image.
If the file looks like "test.jpg" we do show the image. 

Both 4.x and IE properly render the image when the file is called "test". 

I believe our unknown decoder should be smart enough to not only sniff for
content types like html but to also sniff for some basic image content types.

Comment 1

[Scott MacGregor]

setting up for .9.2. The change should be pretty straightforward. This bug came
from some guys at Sun where this is becoming a corporate escalation for them. 

Comment 2

[Scott MacGregor]

Attachment: proposed fix. Ripped the sniffing code out of libpr0n.

Comment 3

[rpotts (gone)]

sr=rpotts

Looks good to me...

Comment 4

[scottputterman]

adding PDT+.  Please check into the trunk as soon as possible.

Comment 5

[tor]

Ian: what is the w3c's current position on content sniffing?

Comment 6

[Hixie (not reading bugmail)]

Is this over HTTP? Over HTTP, if there is a Content-Type, then we should never
ever sniff. If this is over file:// then I guess we can do what we like.

The W3C position, last time I heard, is that sniffing is evil, very evil.

Comment 7

[Scott MacGregor]

if we got here then there wasn't a content type. This is primarily intended for
local files. I believe this is a desired behavior for images in this scenario. 

Comment 8

[benc]

-> file, +qa
clarified summary.

Comment 9

[Christopher Blizzard (:blizzard)]

a=blizzard on behalf of drivers for the tip

Comment 10

[Scott MacGregor]

fix checked in. To test, try opening some image local files that don't have
extensions. 

instead of "test.jpg, test2.gif", rename the files to just be "test" and "test2". 

Comment 11

[Tom Everingham]

verified - 071801 builds, all platforms

Comment 12

[benc]

This sounds like it affects more than just local files, but also ftp:// files 
and headerless (HTTP 0.9) files w/ extensions?