83426 - Remove DOM exception hack from XPConnect.

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[Johnny Stenback (:jst)]

When the XPCDOM changes landed we checked in a hack in XPConnect that made its
exception objects look more like the DOM exception objects, this hack should be
removed and replaces with using the nsIExceptionProvider service for creating
DOM exceptions. David has the XPConnect part partially fixed in his tree, and I
have part partially fixed in my tree.

Comment 1

[David Bradley]

jst, let me know if we need to move this to 1.0. I'm just wanted to get 
something in there for now.

Comment 2

[David Bradley]

Moving out.

Comment 3

[David Bradley]

Moving out

Comment 4

[David Bradley]

Attachment: Patch that replaces the old DOM Exception code

Comment 5

[David Bradley]

r= for jst's part of the patch
Happy Holloween

Comment 6

[John Bandhauer]

- The part in xpcthrower.cpp is a little broken in a couple of ways...

+            if (finalException == nsnull)
+            {
+                defaultException = finalException;
+            }

The assignment is backwards.

You should still check for finalException before attempting to throw it. It can 
be null because you never checked that defaultException was not null (and this 
code assumes that tls could have ben null too). So, you should still do:

  if(finalException)
      success = ThrowExceptionObject(cx, finalException); 

- I see "if (" here!

- funny about the column number business :)

- I notice that nsXPCException::CanGetProperty still lists the property "code" 
which is no longer present. That could be removed. We should think about adding 
in some of the properties on nsIException; many were not originally present. For 
the DOM expection all the scroptable ones will be visible. But for arbitrary xpc 
exceptions we might want to exposes some info we are not exposing now.

- jst has a few assertions to add that he and I discussed.

fix the txpcthrowser stuff and sr=jband

Comment 7

[Johnny Stenback (:jst)]

Attachment: New patch for nsDOMException.cpp

Comment 8

[Johnny Stenback (:jst)]

With the issues jband commented about fixed, r=jst for dbradley's changes.

Comment 9

[David Bradley]

Attachment: Final patch containing both jst's changes, and jband's suggestions

Comment 10

[David Bradley]

patch checked in

Comment 11

[David Bradley]

Forget to mark fixed

Comment 12

[David Bradley]

Ok lets try to mark this fixed one more time. Sorry for the spam

Comment 13

[Phil Schwartau]

Marking Verified -