84123 - Image information is shown on title bar only after image is completely loaded

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[doctor__j]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9+) Gecko/20010604
BuildID:    2001060420

It would be more convenient if the image information is shown on the title bar
once the image is being loaded, instead of after the image (especially the large
ones) is completely loaded.  That would speed up the guessing work of image size
(useful for slow connections like modem...)

Reproducible: Always
Steps to Reproduce:
1. Open a browser window.
2. Load some images, preferrably large ones.

Actual Results:  Image information is shown on title bar only after image is
100% loaded.

Expected Results:  Image information is shown on title bar once sufficient bits
of the image is loaded.

Comment 1

[Asa Dotzler [:asa]]

-->Apps

Comment 2

[sairuh (rarely reading bugmail)]

not sure if this is imagelib, but over to terri who tests image stuff.

terri/pavlov, would this be an imagelib issue, or xp apps?

Comment 3

[Peter Trudelle]

marking future

Comment 4

[Asa Dotzler [:asa]]

-> default assignee

Comment 5

[Andrei Boros]

Also related to this same behaviour: 

when an image is loading in the browser (url=image), CTRL-S, File->Save As,
right click Save Image As will only popup the save as dialog _after_ the image
has finished loading.

Might be related to #133732 also (?)

And also it might be related to the bug that allows multiple downloads of the
same filename, because files are saved to a temp dir and only ater download has
finished, they are moved to the proper location. Don't remember the bug # though.

Comment 6

[Andrei Boros]

Comment #5 save as only after image loads, possibly related to bug #58777

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

-> Image: Layout

content/html/document/src line 488ff:
nsresult
nsImageDocument::EndLayout(nsISupports *ctxt, 
                           nsresult status)
{
  // Layout has completed: now update the title
  UpdateTitle();

  return NS_OK;
}

so, the title does not get set until after layout is finished, which I suppose
is when the image is loaded.

Comment 8

[Kalin Kozhuharov]

I wonder how does this go along with auto image resizing...

Comment 9

[Brian 'netdragon' Bober]

Biesi: That code has disappeared from the tree, and there is some function now
called UpdateTitleAndCharset(); 

I don't have a latest version of Mozilla. Can someone with the most recent build
please check to see if this is fixed?

Kalin: Related, but not a dependency

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

not fixed in a current build

the UpdateTitleAndCharset call is now in nsImageDocument::OnStopRequest
http://lxr.mozilla.org/seamonkey/source/content/html/document/src/nsImageDocument.cpp#171

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

taking, have a patch

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 13

[Boris Zbarsky [:bzbarsky]]

Do you still need the call in OnStopRequest?

Comment 14

[Jan Varga [:janv]]

Comment on attachment 140864 [details] [diff] [review]
patch

looks good, but as bz pointed out, check if it works correctly w/o the call in
OnStopRequest

Comment 15

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140864 [details] [diff] [review]
patch

sr=bzbarsky; biesi pointed out that broken images happen.

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

thanks for the fast reviews

Checking in nsImageDocument.cpp;
/cvsroot/mozilla/content/html/document/src/nsImageDocument.cpp,v  <-- 
nsImageDocument.cpp
new revision: 1.116; previous revision: 1.115
done