844693 - Remove MacIOSurfaceImage::SetUpdateCallback

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: Remove!

This was added by 634521 so that non-async plugins (on OSX) could still take advantage of empty transactions.

I believe all mac plugins (or at least all of the ones we care about) are now properly async, so this can be removed.

We could also probably change the plugin code to use a SHARED_SURFACE image type, rather than the MAC_IO_SURFACE type. This would let us share the rendering code for that with android, and remove the MacIOSurfaceImage type entirely.

We shouldn't do this until after the refactoring lands though.

Comment 1

[Benoit Girard (:BenWa)]

A bit behind in my reviews. I'll get to it early next week unless you tell me it's high priority.

Comment 2

[Matt Woodrow (:mattwoodrow)]

It isn't. Just tidying up old cruft.

Comment 3

[Benoit Girard (:BenWa)]

(In reply to Matt Woodrow (:mattwoodrow) from comment #0)
> I believe all mac plugins (or at least all of the ones we care about) are
> now properly async, so this can be removed.

Except for in-process plugins which can't be async since they run off the main thread.

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 717713 [details] [diff] [review]
Remove!

Much nicer. Just make sure to test by forcing 32-bit mode, and again in 32-bit + dom.ipc.plugins.enabled.i386.* to false. Run a quick test with Quicktime, Flash, Unity and silverlight if you can.

Comment 5

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3abd4a5ff417

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3abd4a5ff417