84692 - Offline UI: Offline panel is too large (to use, for some people)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Backend, defect)

Description

[Håkan Waara]

The Offline panel in Account Settings is too large for me to see it all at once,
usually, so I have to resize it. This isn't good, especially considering that I
have a resolution of 1024x678.

However, I think there are ways to make this panel lots smaller and thus
enabling it for more users!

The panel, or rather the groupbox "Offline Space", has some extensive use of
radiobuttons and checkboxes. I think you can switch to use popupmenus and/or
some other nifty widget here.

Mpt, Jglick?

Comment 1

[David :Bienvenu]

This is you, right bhuvan?

Comment 2

[grylchan]

Also see bug 80134 for comments on this problem..

Comment 3

[racham]

David..that's me. bhuvan ([e-mail]). Accepting.. I think we have a
similar bug to shrink the AcctMgr window in general.

Comment 4

[Håkan Waara]

Bhuvan, do you think you could do this before the 1.0 milestone? (Nominating.)

Comment 5

[jglick]

This is just for News Accounts right?  IMAP and POP accounts are not being cut 
off?  If so, isn't this a dup of 81753?

Comment 6

[timeless]

Attachment: QNX can't see that second group box

For now can we just split this into two panels? please?

Comment 7

[sairuh (rarely reading bugmail)]

is there anyone here who can test this on win32 with Large Fonts turned on for
Display Settings? unfortunately, my winNT box lacks said fonts. :(

anyhow, this bug might crop up in a win32/large font situation, in which case
this panel would be practically unusable. it'd be great if someone could confirm
this!

Comment 8

[sairuh (rarely reading bugmail)]

thanks to stephend, we were able to reproduce the problem mentioned in comment
7. tested on win2k, with large fonts and screen resolution of 800x600. this
renders that panel unusable --an accessibility issue, at least.

so, would it be possible to fix this before moz1.1?

Comment 9

[jglick]

Attachment: Remove group boxes

How do folks feel about removing the group boxes? This should provide the
needed vertical space.

Comment 10

[jglick]

Attachment: Account Settings - Offline - Newsgroup Acct

This Offline & Diskspace panel is also cropped. Suggest removed groupboxes as
well.

Comment 11

[grylchan]

Adding a comment that another bug, bug 99685, possibly related
to this one. As localization group would like:

"..default size be externalized to a 
resource file, since the default sizes for localized builds 
could be different with the one for English build."

Comment 12

[grylchan]

*** Bug 149697 has been marked as a duplicate of this bug. ***

Comment 13

[grylchan]

*** Bug 153844 has been marked as a duplicate of this bug. ***

Comment 14

[varada]

taking from bhuvan

Comment 15

[jglick]

Using 2002100708 Trunk build, looks like "when starting <productname>:" plus its
two radio button options is missing. Is this on purpose?

Comment 16

[[e-mail] (gone - use [e-mail] instead)]

Jennifer, this was done in bug 132896.

Comment 17

[jglick]

Thanks for the info Stephen. Looks like cropping on this panel isn't an issue
right now. If ui for 'offline: ask me at startup & remember prev mode' gets
re-added, cropping will be an issue again.

Comment 18

[jglick]

>If ui for 'offline: ask me at startup & remember prev mode' gets
>re-added, cropping will be an issue again.

Bug 82487 - offline: Startup mode doesn't work-"remember my prev mode" or "Ask
me at startup".

Comment 19

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 20

[R. D. Flowers]

It blocks the horrendous 133627, and imho it needs gone.

Comment 21

[Stefan Borggraefe]

Attachment: Proposed patch

Another idea how to fix this bug. This makes use of the fact that currently the
preferences pane has a lot of repeating redundant text:

- the "When going online" option repeats the phrase "send my unsent messages"
  three times.
- the "When going offline" option repeats the phrase "download messages for
  offline use three times.

I moved this text in the labels above the radio buttons and changed the radio
buttons to just "Yes", "No" and "Ask me".

I'll attach a screenshot in a minute...

Comment 22

[Stefan Borggraefe]

Attachment: Screenshot with "Proposed patch" applied

Feedback welcome!

Comment 23

[David :Bienvenu]

I think that's good. Much cleaner.

Comment 24

[timeless]

Comment on attachment 144256 [details] [diff] [review]
Proposed patch

This is not good English:
When going online, send unsent messages: Yes.

You could do:

Should unsent messages be sent when going online?
Yes. No. Ask me.

i know it's longer :(

Comment 25

[Stefan Borggraefe]

Attachment: Same as the previous patch, but using better English

Compared to the previous patch this just changes

"When going online, send unsent messages:" to "Send unsent messages when going
online?"

and

"When going offline, download messages for offline use:"  to "Download messages
for offline use when going offline?"

So these are now proper questions the user answers with "Yes", "No" or "Ask
me".

Comment 26

[Stefan Borggraefe]

Attachment: Screenshot of the latest patch in action

Comment 27

[u60234]

But is'nt this bug about the Offline panel in Account Settings?

Comment 28

[Stefan Borggraefe]

(In reply to comment #27)
> But is'nt this bug about the Offline panel in Account Settings?

Looks like this bug morphed a bit. I think timeless is guilty (comment #6). ;-)

The Offline & Disk Space pane in the Account Settings was already shrinked in
bug 222940. For me it now fits in all configurations I tried (I can test on
Linux and Windows). If this still isn't the case for you, it would be probably
better to file a new bug.

Comment 29

[Stefan Borggraefe]

Fix checked in.

Comment 30

[Stefan Borggraefe]

*** Bug 96541 has been marked as a duplicate of this bug. ***