Closed Bug 84778 Opened 24 years ago Closed 24 years ago

Pages with iframes get an error dialog referencing framesets, it should refernece iframes

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9.3

People

(Reporter: t.terlemez, Assigned: sfraser_bugs)

References

()

Details

(Whiteboard: [nsBranch+,PDT+])

Attachments

(3 files)

Hello I am taking from Composer : "This Editor cannot edit HTML framesets. Try editing the page for each frame separately." when I try to edit my "not framed - plain" page. Composer is closing own after this message. I am using Mozilla 0.9.1, Win2000 prof.
over to editor
Assignee: kmcclusk → beppe
Component: Compositor → Editor
QA Contact: petersen → sujay
there is an iframe at the bottom of the page, that is the culprit, the dialog that displays should be updated to state framesets and ifrmaes, or have a different dialog specifically for iframe. Handing off to sfraser.
Assignee: beppe → sfraser
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Summary: I am taking "This Editor cannot edit HTML framesets. Try editing the page for each frame separately." when I try to edit my "not framed - plain" page. → apges with iframes get an error dialog referencing framesets, it should refernece iframes
Target Milestone: --- → mozilla0.9.3
Status: NEW → ASSIGNED
OS: Windows 2000 → All
Hardware: PC → All
Summary: apges with iframes get an error dialog referencing framesets, it should refernece iframes → Pages with iframes get an error dialog referencing framesets, it should refernece iframes
Hello I see that the page can be edited when working offline, but when machine is online iframe is working (I dont understand what is iframe, it is a copy-paste code from geobutton).
r=brade do we need i18n approval for this change?
although it is a string change, this should get fixed reviewed and approved
Keywords: nsBranch
Looking for UI change approval
approving since Michele is out; please land asap (before 7/5 anyway)
Attached file Simpler test case
blake: sr please?
Ugh, this is really lame. I wish editor would just strip the iframe tag on its own. Seems weird to say "<iframe>s" when everywhere else we talk about the elements generically (e.g. "framesets"). But the wording is up to you, so if you're okay with it, sr=blake...
Fixed on trunk. Holding open for branch.
Keywords: vtrunk
nsBranch+
Whiteboard: nsBranch+
mark PDT+ to check into the branch. If possible, pls get this in for Friday am builds.
Whiteboard: nsBranch+ → [nsBranch+,PDT+]
Checked into the branch.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Terlemez, is this fixed for you now? try again in latest build.
verifed on 7/9 branch and trunk build. I simply opened up Simon's simple test case and tried to Edit Page. "I got the Alert panel: "Composer cannont edit HTML framesets, or pages with inline frames. For framesets, try editing the page for each frame separately. For pages with iframes, save a copy of the page adn remove <iframe> tag." I think this is all I have to do to verify this bug. Therefore this bug is fixed. marking verified fixed. also removing vtrunk keyword.
Status: RESOLVED → VERIFIED
Keywords: vtrunk
Hello I tried to edit my page with mozilla 2001070504 - win2000 prof. Yes error message is true for case, it is fixed thanks.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: