84825 - Dialog to create master password inflexible

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P2)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

When you enable encryption of your personal information, you need to create a
master password. The dialog where you create it is fixed size. If you make
Windows use larger than standard system font, you cannot submit this dialog
since the buttons are not visible, you cannot resize the dialog and there is no
default action for ENTER key.

Comment 1

[sairuh (rarely reading bugmail)]

i cannot remember if master passwd stuff belongs in crypto or passwd mgr...

Comment 2

[John Unruh]

PSM

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I think you better check ALL the dialogs the security code pops up. I just went
to a site that popped up the certificate warning dialog and I did not see the
OK/Cancel buttons and therefore could not enter the site. (www.icelandair.com,
fill in the flight info and hit submit).

Comment 4

[Stephane Saux]

target -> 2.1
P2

Comment 5

[John Unruh]

*** Bug 91150 has been marked as a duplicate of this bug. ***

Comment 6

[Stephane Saux]

rangansen

Comment 7

[John Unruh]

*** Bug 91686 has been marked as a duplicate of this bug. ***

Comment 8

[Rangan Sen]

Attachment: patch

Comment 9

[Rangan Sen]

Here is a suggested patch - please review

Comment 10

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Please fix ALL the PSM dialogs (like the certificate warning dialog etc.) I am
raising the severity to major since it seems a lot of people with new computers
are affected with this (new computers with high screen resolutions tend to make
people use large fonts) and this can actually make it impossible to use some
services (like the Icelandair I mentioned 2001-06-13 16:15).

Comment 11

[ji]

It also affects localized version of mozilla, like Japanese, which requires 
bigger size of the window to accommodate the translation of the UI.

Comment 12

[David P. Drinan]

r=ddrinan.

Comment 13

[Joe Hewitt (gone)]

sr=hewitt

Comment 14

[Stephane Saux]

adding patch keyword.

Comment 15

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I am just saying this once more, in case you missed it. Please fix ALL the PSM
dialogs. If you just fix this one in the patch I am going to have to file a new
bug saying the same thing I have said here, which would be stupid, right? The
fix will be most likely similar to the one in the patch...

Comment 16

[John Unruh]

Mass assigning QA to ckritzer.

Comment 17

[Rangan Sen]

Heikki -
In fact, we are looking at this issue. Also, many of these sizing problems 
actually originate in xp toolkit issues - for example, you might be interested 
in taking a look at bug# 91137 - though this is not directly related to this 
particular problem, solving it will resolve many of the windows sizing issues. 

Comment 18

[Javier Delgadillo]

Checked in patch for Rangan.

Comment 19

[Stephane Saux]

keywords->verifyme

Comment 20

[John Unruh]

Verified on 8/2 WinNT trunk.

Comment 21

[ji]

A question: are those window size externalized to a property file (not only
resizable)? Localized builds need to set proper initial size for those dialog
windows. Thanks.