850154 - The Find in Page bar is displayed over the URL bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Adrian Tamas (:AdrianT)]

Attachment: screenshot

Nightly 22.0a1 2013-03-11
Asus EEE Transformer TF101 (Android 4.0.4) / Samsung Galaxy Tab 2 7.0 (Android 4.0.4)

Steps to reproduce:
1. Load any webpage with text ( for e.g. the mozilla webpage on wikipedia)
2. Open Find in Page

Expected results:
The Find in Page bar overlaps the URL bar perfectly just like on phones

Actual results:
The bottom edge of the URL bar is still visible because the Find in page bar does not have the same height as the URL bar

Note:
At the moment this is only reproducible on Nightly since only there the Find in Page Bar is displayed on top of the screen although I did not find the bug where this change has been added

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Uhh isn't the find in page bar supposed to be at the bottom of the screen? This may have been introduced by bug 716403.

Comment 2

[Chris Lord [:cwiiis]]

uh, yes... I'll have a look at this.

Comment 3

[Adrian Tamas (:AdrianT)]

Changing the title then to reflect the underlining issue of the Find in Page bar being displayed on top of the URL bar.

Comment 4

[Chris Lord [:cwiiis]]

Attachment: Align find-in-page bar to the bottom of the app

Restore the previous behaviour.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 725457 [details] [diff] [review]
Align find-in-page bar to the bottom of the app

Review of attachment 725457 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/resources/layout/gecko_app.xml.in
@@ +28,5 @@
>                          android:layout_width="fill_parent"
>                          android:layout_height="fill_parent"
>                          android:layout_weight="1"
> +                        android:layout_below="@+id/toolbar_spacer"
> +                        android:layout_above="@+id/find_in_page">

I think the idea is have the Find-in-page "over" the content. This attribute will make it resize the page and show it below it.
If this is the approach we want, please remove android:layout_weight="1"

@@ +42,5 @@
>  
>          <org.mozilla.gecko.FindInPageBar android:id="@+id/find_in_page"
>                                           android:layout_width="fill_parent"
>                                           android:layout_height="wrap_content"
> +                                         android:layout_alignParentBottom="true"

Just this should be fine. Could you try removing the above one?

Comment 6

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 725457 [details] [diff] [review]
Align find-in-page bar to the bottom of the app

Review of attachment 725457 [details] [diff] [review]:
-----------------------------------------------------------------

I think I am wrong. The find-in-page shouldn't be over the content. This will work. Please remove the "layout_weight" attribute alone. r+ with that.

Comment 7

[Chris Lord [:cwiiis]]

Pushed to inbound with amendment from comment #6: https://hg.mozilla.org/integration/mozilla-inbound/rev/97ca1fe7446f

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/97ca1fe7446f

Comment 9

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 22.0a1 (2013-03-28) 
-device: LG Nexus 4
-OS: Android 4.2.2