85189 - cleanup of ListIterator

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The ListIterator can operate in reversed mode which clutters the ListIterator 
code a lot. This is only used for stacks and PathExpr and can easily be removed.

I have a patch which removes the reversed mode as well as remove the 
allowRemove flag which dosn't surve any purpose, and the count member which 
isn't used.

I've also added |move| |addBefore| and |moveToEnd| methods which i'll need 
later.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: first attempt

Comment 2

[Axel Hecht]

List::previous() should unset atEndOfList in the 
else if ( atEndOfList )
part instead of setting this just when going past the head.

reuse forward in ListIterator::advance
if ( i > 0 ) {

Axel

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: second attempt

Comment 4

[Axel Hecht]

r=me

Axel

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: whitespace cleanup

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

did some whitespace cleanup and added myself as contributor

Comment 7

[Peter Van der Beken [:peterv]]

Hah, I found two nits ;), space out the arguments in
+        list->insertAfter(objPtr,currentItem);
and
+        list->insertBefore(objPtr,currentItem);

r=peterv.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

damn! :)

oh well, consider it fixed

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

no reason to aim this for 0.9.2

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

cc'ing scc for sr, adding another this-bug-blocks

Comment 11

[Scott Collins]

sr=scc

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in

Comment 13

[Axel Hecht]

bitching buttons, verfication spam