852163 - GeckoApp is leaked with Don't keep activities

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

When "Don't keep activities" is set (and/or when GeckoApp is killed and recreated), it gets leaked from here:

Static reference from org.mozilla.gecko.PrefsHelper.sCallbacks (from class org.mozilla.gecko.PrefsHelper) :
--> java.util.HashMap@0x41554458 (48 bytes) (field table:)
--> java.util.HashMap$HashMapEntry[]@0x41581c10 (40 bytes) (Element 6 of java.util.HashMap$HashMapEntry[]@0x41581c10:)
--> java.util.HashMap$HashMapEntry@0x415830a0 (24 bytes) (field value:)
--> org.mozilla.gecko.BrowserApp$7@0x415d0a98 (12 bytes) (field this$0:)
--> org.mozilla.fennec_kats.App@0x415c5300 (329 bytes)

It looks like the "isObserver()" on the prefs helper callback means it never gets unregistered and hangs on to the enclosing Activity class.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

I used an Integer instead of an int just to try and keep the actual value of the id more opaque (i.e. it is allowed to be negative and we still handle it just fine).

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 726194 [details] [diff] [review]
Patch

Review of attachment 726194 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22d16e3d3ea1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/22d16e3d3ea1