853075 - Self-hosted code can't call methods that are listed after first self-hosted function in method array

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Norbert Lindenberg]

Attachment: Test case - do not check in

Self-hosted code can't call methods that are listed after the first self-hosted function in the containing class's method array.

In the attached test case patch, testCallFilter calls Array.prototype.filter. filter is listed in array_methods after several self-hosted functions, lastIndexOf to reduceRight. Output from the js shell with this patch applied:

js> print([].testCallFilter)
function testCallFilter() {
    [native code]
}
js> print([].testCallFilter())
typein:2:0 TypeError: undefined is not a function

After moving the entry for filter in array_methods to above lastIndexOf and rebuilding, you get the desired output:

js> print([].testCallFilter)
function testCallFilter() {
    [native code]
}
js> print([].testCallFilter())
hello world!

Comment 1

[Norbert Lindenberg]

The patches in bug 769871 add workarounds for this bug to the method arrays in jsstr.cpp, jsnum.cpp, and jsdate.cpp. The files should be cleaned up when this bug is fixed.

Comment 2

[Till Schneidereit [:till]]

Attachment: Continue with next FunctionSpec instead of aborting loop upon encountering self-hosted methods during self-hosting global initialization in JS_DefineFunctions.

Well, this is embarrassing. Stopping the definition of a builtin's methods upon encountering the first self-hosted one might not actually be a good move. Not even during initialization of the self-hosting global ...

r=jonco via IRC

Comment 3

[Till Schneidereit [:till]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a49b82d16504

Comment 4

[Norbert Lindenberg]

Attachment: Remove workarounds

Comment 5

[Till Schneidereit [:till]]

Comment on attachment 730179 [details] [diff] [review]
Remove workarounds

Review of attachment 730179 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1de74b4a773

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a49b82d16504

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d1de74b4a773