85484 - Proxy: auth prompt doesn't show realm

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christian Schmidt]

When I try to connect to a page using an authenticating proxy server I am
prompted 'Enter username and password for proxy at myproxy.mydomain.tld:5555'.

Expected result:
A prompt saying 'Enter username and password for "My Proxy Realm" at
myproxy.mydomain.tld:5555' (where My Proxy Realm is the actual realm of the
proxy authentication) like it works with regular basic authentication.

I guess this is a minor bug since most people probably use only one password for
their proxy server(s).

Comment 1

[Keyser Sose]

marking NEW.

Comment 2

[benc]

+qawnated.
I never bothered to look for realms in my Proxy Auth configs or packet traces...

Comment 3

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 4

[benc]

+mozilla 1.0

part of a well established RFC.

Comment 5

[Doug Turner (:dougt)]

moving neeti's futured bugs for triaging.

Comment 6

[benc]

+clean-report.
default owners and target, to put into triage query, per #7.

A comment in bug 60026 said realm does appear, so this might be working already.

My main test proxy seems to use a realm of "unspecified", so I cannot confirm if
this is WFM or not.

Comment 7

[Doug Turner (:dougt)]

-> darin

Comment 8

[wbayer]

I logged duplicate bug 210848 on this issue. The proxy authentication challenge
display of the "My Proxy Realm" is still not working as of Mozilla 1.4RC3. I'll
close 210848 and add a vote to this bug.

Comment 9

[wbayer]

*** Bug 210848 has been marked as a duplicate of this bug. ***

Comment 10

[wbayer]

This is working properly as of Mozilla 1.4 final (Mozilla/5.0 (Windows; U;
Win98; en-US; rv:1.4) Gecko/20030624). It also works with Netscape 7.1.

Comment 11

[Olivier Cahagne]

Marking WFM as per reporter comments.

Comment 12

[Darin Fisher]

no, this bug is not fixed.  for proxy auth, the dialog does not show the realm
string.  REOPENING.

Comment 13

[benc]

now a testcase

Comment 14

[Christian Schmidt]

Attachment: Fix

This patch adds the realm to the proxy dialog.

I am not used to hacking C++ so bear with me if it isn't done right.

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 144409 [details] [diff] [review]
Fix

+    const PRUnichar *strings[] = { ToNewUnicode(nsDependentCString(realm)),

this leaks memory... you should nsMemory::Free(strings[0]) after the
FormatStringFromName call

Comment 16

[Christian Schmidt]

Attachment: Patch that (hopefully) doesn't leak

Comment 17

[Darin Fisher]

Attachment: v1.1 patch

revised patch.	better to use NS_ConvertASCIItoUTF16 instead of ToNewUnicode. 
that way you avoid a heap allocation in most cases.

Comment 18

[Darin Fisher]

-> 1.8 alpha since we're already into the localization freeze for 1.7 final.

Comment 19

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 145123 [details] [diff] [review]
v1.1 patch

sr=bzbarsky

Comment 20

[benc]

CONFIRIMED:
Testcase available @ mozilla office.
contact me for the config info.

Proxy-authenticate: basic realm="is this a realm"

For anyone using Netscape Proxy Server, the configuation is under:
Restrict Access -> Deny -> "Login Prompt"

Also, while I'm here, I noticed that the proxy auth dialog does not display the
port number. Should I file a separate bug?

Comment 21

[Darin Fisher]

fixed-on-trunk for 1.8beta

> Also, while I'm here, I noticed that the proxy auth dialog does not display the
> port number. Should I file a separate bug?

I modified the patch to fix this problem.  Thanks for pointing it out.