854850 - Allow tapping on the toolbar while menu is open

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Peter Retzer (:pretzer)]

Bug 853300 added the possibility to bring up the dynamic toolbar with the HW menu button some phones still have (Galaxy S2/S3, etc.).

Now if you bring up the toolbar with the HW button it takes two taps to open the awesomescreen/tabs tray/reader mode, because the first tap only closes the open app menu.
It would be nice if the first tap would be directly applied to the toolbar instead.

Comment 1

[Peter Retzer (:pretzer)]

That would match the behavior of the stock browser, btw.

Comment 2

[Chris Lord [:cwiiis]]

That's great, but this has never been possible and really doesn't have much to do with the dynamic toolbar - removing it as a blocker (bug is fair though).

Cc'ing mfinkle to get front-end comment.

Comment 3

[Ian Barlow (:ibarlow)]

I'm not sure we want this, since no other Android apps really behave this way, that I'm aware of. 

It's also worth mentioning that if you want to focus the URL bar, a more efficient approach (than menu->tap->tap) would be to simply pull down to reveal and then tap the bar.

Comment 4

[Lucas Rocha (:lucasr)]

Removing from hackathon.

Comment 5

[Aaron Train [:aaronmt]]

Smells like wont-fix

Comment 6

[Matt Brubeck (:mbrubeck)]

(In reply to Ian Barlow (:ibarlow) from comment #3)
> I'm not sure we want this, since no other Android apps really behave this
> way, that I'm aware of. 

As comment 0 pointed out, the stock browser does work this way (at least on my Android 2.3 phone).

Without this fix, bug 853300 is much less useful.  I would really like to fix this if there's a feasible way to do it.

Comment 7

[Peter Retzer (:pretzer)]

Ian, can you comment again if this is a go or no-go? I'd really like to break the status quo here, one way or the other...

Some information: Stock browser does still allow tapping on the toolbar right away on Android 4.1. Chrome (which also has a dynamic toolbar as of late) does behave like Firefox does right now, meaning it needs two taps to access the toolbar buttons.

I know it's just 1 tap vs. 2 taps and we have a pref now to turn dynamic toolbar off, but it'd still be a more convenient interaction flow for users, if this bug got fixed.

Comment 8

[Ian Barlow (:ibarlow)]

Reading this bug again, it sounds like a useful fix to me. Sorry for pushing back on it earlier, not entirely sure what my rationale was there ;)

Comment 9

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.