8557 - typing in a text area in the profile manager causes a crash

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

this is on my 06-19-99 build.

remove profile registry.
start apprunner
get to the second screen
crash when you type in the text area.

stack trace coming shortly.

Comment 1

[Simon Fraser [no longer active]]

Checked in a simple null check fix:

Index: nsRangeList.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/base/src/nsRangeList.cpp,v
retrieving revision 1.104
retrieving revision 1.105
diff -r1.104 -r1.105
1085a1086,1088
>
>   nsresult	result = NS_OK;
>
1087c1090,1093
<   nsCOMPtr<nsIContent> content = do_QueryInterface(node);
---
>   nsCOMPtr<nsIContent> content = do_QueryInterface(node, &result);
>   if (NS_FAILED(result) || !content)
>     return result;
>
1089c1095
<   nsresult result = content->CanContainChildren(canContainChildren);
---
>   result = content->CanContainChildren(canContainChildren);

Comment 2

[(not reading, please use [e-mail] instead)]

more detail:

I selected text in the text area when it comes up (mozProfile) and then started
to type, and then it crashed.

Here's the stack trace.

NTDLL! 77f76148()
nsDebug::PreCondition(const char * 0x016328dc
??_C@_0DJ@KMGL@You?5can?8t?5dereference?5a?5NULL?5nsC@, const char * 0x01632920
??_C@_0N@NHHF@mRawPtr?5?$CB?$DN?50?$AA@, const char * 0x01635030
??_C@_0CB@MCGB@?4?4?2?4?4?2?4?4?2dist?2include?2nsCOMPtr?4h@, int 477) line 126
+ 13 bytes
nsCOMPtr<nsIContent>::operator->() line 477 + 34 bytes
nsRangeList::GetPrimaryFrameForFocusNode(nsRangeList * const 0x018a5570,
nsIFrame * * 0x0012f8dc) line 1089 + 12 bytes
nsRangeList::HandleKeyEvent(nsRangeList * const 0x018a5570, nsGUIEvent *
0x0012fb94) line 1028 + 16 bytes
PresShell::HandleEvent(PresShell * const 0x018a55f4, nsIView * 0x018c8b50,
nsGUIEvent * 0x0012fb94, nsEventStatus & nsEventStatus_eIgnore) line 2018
nsView::HandleEvent(nsView * const 0x018c8b50, nsGUIEvent * 0x0012fb94, unsigned
int 8, nsEventStatus & nsEventStatus_eIgnore, int & 0) line 833
nsView::HandleEvent(nsView * const 0x018ae190, nsGUIEvent * 0x0012fb94, unsigned
int 8, nsEventStatus & nsEventStatus_eIgnore, int & 0) line 818
nsView::HandleEvent(nsView * const 0x018b8890, nsGUIEvent * 0x0012fb94, unsigned
int 8, nsEventStatus & nsEventStatus_eIgnore, int & 0) line 818
nsView::HandleEvent(nsView * const 0x018b9090, nsGUIEvent * 0x0012fb94, unsigned
int 8, nsEventStatus & nsEventStatus_eIgnore, int & 0) line 818
nsView::HandleEvent(nsView * const 0x018a59d0, nsGUIEvent * 0x0012fb94, unsigned
int 28, nsEventStatus & nsEventStatus_eIgnore, int & 0) line 818
nsViewManager::DispatchEvent(nsViewManager * const 0x018a5bf0, nsGUIEvent *
0x0012fb94, nsEventStatus & nsEventStatus_eIgnore) line 1735
HandleEvent(nsGUIEvent * 0x0012fb94) line 67
nsWindow::DispatchEvent(nsWindow * const 0x018c8a14, nsGUIEvent * 0x0012fb94,
nsEventStatus & nsEventStatus_eIgnore) line 408 + 10 bytes
nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012fb94) line 429
nsWindow::DispatchKeyEvent(unsigned int 133, unsigned short 0, unsigned int 83)
line 1823 + 15 bytes
nsWindow::OnKeyDown(unsigned int 83, unsigned int 31) line 2016
nsWindow::ProcessMessage(unsigned int 256, unsigned int 83, long 2031617, long *
0x0012fd8c) line 2341 + 40 bytes
nsWindow::WindowProc(HWND__ * 0x00bd01b4, unsigned int 256, unsigned int 83,
long 2031617) line 471 + 27 bytes
nsTextWidget::TextWindowProc(HWND__ * 0x00bd01b4, unsigned int 256, unsigned int
83, long 2031617) line 121
USER32! 77e71250()

I'll update and rebuild and try sfraser's fix.

Comment 3

[(not reading, please use [e-mail] instead)]

sfraser fix works on windows.

marking fixed.

Comment 4

[leger]

gbush, could you verify fix please?

Comment 5

[Grace Bush]

build 1999062115

Comment 6

[leger]

Moving all Profile Manager bugs to new Profile Manager Backend component.
Profile Manager component to be deleted.