856325 - [AccessFu] We do not support double-tap and hold in web content to bring up an item's context menu

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

STR:
0. Enable TalkBack.
1. Open any site.
2. Focus on a link.
3. Double-Tap, but don't lift your finger, but instead keep it on the display.

Expected: After a second or so, the item's context menu should appear.
Actual: Not half a second after the double-tap, TalkBack recognizes the finger on the display as an exploration touch instead of still belonging to the double-tap. There is no way to bring up the context menu.

This is not new in 22, I also reproduced this problem in 20. It prevents blind users from opening the context menu of a link, for example to save the link target etc.

Comment 1

[Max Li [:maxli]]

Attachment: Patch

Comment 2

[Marco Zehe (:MarcoZ)]

I just tried this patch on a local build, and it works fine on Jelly Bean. :-)

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 756962 [details] [diff] [review]
Patch

Review of attachment 756962 [details] [diff] [review]:
-----------------------------------------------------------------

I like the addition for TouchAdapter, very clean. A lot of this needs to be separated out into the content script, as I explain below.

::: accessible/src/jsat/AccessFu.jsm
@@ +661,5 @@
>      mm.sendAsyncMessage('AccessFu:Activate', {});
>    },
>  
> +  activateContextMenu: function activateContextMenu() {
> +    let accessible = Utils.getVirtualCursor(Utils.CurrentContentDoc).position;

As a rule, we don't access accessible objects directly in this script because we need to accommodate out-of-process content. So we typically send a message to the appropriate content script. In Android, we are all in-process, but we should still assume it is not so that if they "flip the switch" and change it to one process per tab, we would still work.

So you want to pass a message, like we do in activateCurrent, and then from the content script, send a message back here that would notify of a long press.

@@ +668,5 @@
> +    let x = objX.value + objW.value / 2;
> +    let y = objY.value + objH.value / 2;
> +
> +    Services.obs.notifyObservers(null, 'Gesture:LongPress',
> +                                 JSON.stringify({x: x, y: y}));

I think this is would only work in Android. In B2G, we would probably dispatch an IndieUI SecondaryAction event, but that should be left for future work.

Comment 4

[Max Li [:maxli]]

Attachment: Patch v2

Comment 5

[Eitan Isaacson [:eeejay]]

Comment on attachment 757637 [details] [diff] [review]
Patch v2

Review of attachment 757637 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good!

Comment 6

[Marco Zehe (:MarcoZ)]

Landed: http://hg.mozilla.org/integration/mozilla-inbound/rev/6fba29e7f379

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6fba29e7f379