863770 - nsBinaryInputStream::ReadAsArrayBuffer needs to take an ArrayBuffer input

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Josh Matthews [:jdm]]

Sometimes it matters in which compartment the ArrayBuffer is created, so we should have consumers pass in one for the method to use instead of creating one itself.

Comment 1

[Josh Matthews [:jdm]]

Attachment: Pass in an ArrayBuffer object for nsBinaryInputStream::ReadAsArrayBuffer to use, for cases when the compartment in which it resides matters.

Comment 2

[Josh Matthews [:jdm]]

This is required to make the email app work after bug 831107.

Comment 3

[Dietrich Ayala (:dietrich)]

Blocks a blocker.

Comment 4

[Andrew Overholt [:overholt]]

It seems like Josh is on this.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 739653 [details] [diff] [review]
Pass in an ArrayBuffer object for nsBinaryInputStream::ReadAsArrayBuffer to use, for cases when the compartment in which it resides matters.

r+, but can you add an explicit comment to watch out if passing in SomeView.buffer, because the view might not start at byte 0 of the buffer.

Comment 6

[Josh Matthews [:jdm]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3b288d222dd1
https://hg.mozilla.org/releases/mozilla-b2g18/rev/e4d44dd7ea32
https://hg.mozilla.org/projects/birch/rev/a991d0f4469b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a991d0f4469b