Closed Bug 86462 Opened 24 years ago Closed 21 years ago

Remove 'text-align:-moz-initial;' from UA CSS

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Future

People

(Reporter: fantasai.bugs, Assigned: annevk)

Details

(Keywords: css-moz, css3, helpwanted)

Attachments

(1 file)

We currently have both "text-align: start" and "text-align: -moz-initial" in the UA stylesheets. Both are implemented, but we should use either one or the other, not both. text-align: start pros - it's in the *CSS3 Text Module* Working Draft cons - it's in the CSS3 Text Module *Working Draft* text-align: -moz-initial pros - it will never be official CSS cons - it's not official CSS Hyatt, I'm assigning to you because you put them both in your patch for bug 78695.
Actually, glazman proposed "initial" to the CSS WG, and my understanding is that they thought is was ok.
Status: NEW → ASSIGNED
Keywords: css-moz, css3
Target Milestone: --- → Future
WONTFIX?
No, we should indeed use one or the other, for cleanliness if nothing else. I think we should use 'start'.
Since the CSS3 Text Module is now a CR Mozilla is encouraged to follow it (<http://www.w3.org/TR/css3-text/#alignment-prop>). If '-moz-initial' is still there, it should be removed.
QA Contact: chrispetersen → ian
Summary: "text-align: start" OR "text-align: -moz-initial" in UA CSS → Remove 'text-align:-moz-initial;' from UA CSS
Assignee: hyatt → dbaron
Status: ASSIGNED → NEW
Component: Layout → Style System (CSS)
Attached patch patchSplinter Review
Thanks Michiel for creating the diff. Without his help I would never be able to change this one line in quirk.css :-D
Attachment #148185 - Flags: review?(bzbarsky)
Attachment #148185 - Flags: approval1.7?
Attachment #148185 - Flags: superreview?(bzbarsky)
Comment on attachment 148185 [details] [diff] [review] patch Removing bz, I heard he is busy enough.
Attachment #148185 - Flags: superreview?(dbaron)
Attachment #148185 - Flags: superreview?(bzbarsky)
Attachment #148185 - Flags: review?(dbaron)
Attachment #148185 - Flags: review?(bzbarsky)
Comment on attachment 148185 [details] [diff] [review] patch Anne, don't flag trivial bugs like this for a release that's already branched. Unless it's a crash fix or dataloss fix, the trunk is fine.
Attachment #148185 - Flags: approval1.7?
Attachment #148185 - Flags: superreview?(dbaron)
Attachment #148185 - Flags: superreview+
Attachment #148185 - Flags: review?(dbaron)
Attachment #148185 - Flags: review+
Assignee: dbaron → bug
Marking my very first, albeit a very simple 1 line change, bug FIXED. Many thanks to Boris and Michiel.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Argh, I forgot the reviewer himself, David, thanks!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: