86526 - chatzilla stores default prefs in prefs.js

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Jesse Ruderman]

Chatzilla shouldn't store its default prefs in prefs.js, because if the defaults
are later changed, anyone who happens to have run chatzilla before the change
will have the old defaults.

Here's what I see in my prefs.js file:

user_pref("extensions.irc.debug.tracer", false);
user_pref("extensions.irc.desc", "New Now Know How");
user_pref("extensions.irc.munger", true);
user_pref("extensions.irc.munger.smileyText", false);
user_pref("extensions.irc.nickCompleteStr", ": ");
user_pref("extensions.irc.nickname", "Jesse");
user_pref("extensions.irc.notify.aggressive", true);
user_pref("extensions.irc.stalkWords", "");
user_pref("extensions.irc.username", "chatzilla");

I think my nick is the only thing I entered.

Comment 1

[Robert Ginda]

This will go away when chatzilla finally gets a prefs panel.

Comment 2

[David Krause]

Remove myself from QA of 33 open Chatzilla bugs and change to default QA
contact, since I have no way to verify these easily.  Still no working Mozilla
on my primary platform and it doesn't look like it will happen anytime soon. :(

Comment 3

[unknown_kev_cat]

Chatzilla now has a pref panel. Is it gone in the latest releases?

Comment 4

[Samuel Sieb]

The pref panel is not checked in yet.

Comment 5

[Robert Ginda]

I don't know what my comment was all about, I don't see how the pref panel
blocks this bug at all.

Comment 6

[James Ross]

I think I know - without the pref panel you just saved the prefs on exit (or if
the user requested), but with the pref panels you can specify a default for each
pref in the panel itself, which cuases the pref to only be stored if it's not
set to the default.

I don't know off-hand if my stuff included in bug 23265 has these defaults in
them or not, but the current working version on my computer certainly does.

Comment 7

[Samuel Sieb]

This is not fixed.  The prefs are stored even if they are the defaults.

Comment 8

[Koike Kazuhiko]

Attachment: patch v0.1

write prefs if they aren't default value.

It's necessary to delete prefs if they are set to default value,
but I couldn't find how to do that. client.prefBranch.clearUserPref()
doesn't work.

Comment 9

[James Ross]

I tried calling clearUserPref("nickname") and that did appear to clear the pref
fine. Could you try again, with the clearUserPref enabled and see if you can get
it to work?

I'm happy to try the patch if you want.

Comment 10

[Koike Kazuhiko]

client.prefBranch.clearUserPref() still doesn't work.
Once that function is called, client.munger.entries is cleared.

Comment 11

[James Ross]

Attachment: diff -U 6 of CVS tee

This is based on the previous patch, and is basically the same except it
catches exceptions generated when trying to clear a pref that's not there.

Comment 12

[Robert Ginda]

Comment on attachment 125701 [details] [diff] [review]
diff -U 6 of CVS tee

included in next xpi

Comment 13

[Robert Ginda]

actually, isn't this going to keep the default values from showing up in the
pref panel?

Comment 14

[Robert Ginda]

marking fixed, 0.8.34 checked in.