867637 - Disable dynamic toolbar in Firefox 22

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Chris Lord [:cwiiis]]

I think it's generally agreed that there has been too much work done on the dynamic toolbar to safely merge it all to Aurora, and there's still some ongoing work. All in all, it would be safer to disable this in 22 and let the extra work ride the trains.

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Disable dynamic toolbar via prefs

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 744168 [details] [diff] [review]
Disable dynamic toolbar via prefs

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Blocking bugs of bug 716403
User impact if declined: Glitchy behaviour with dynamic toolbar
Testing completed (on m-c, etc.): Tested locally, just disables pref
Risk to taking this patch (and alternatives if risky): Low risk
String or IDL/UUID changes made by this patch: None

Comment 3

[Alex Keybl [:akeybl]]

Given the number of tracked bugs, this makes sense to me. Please make sure to mark the status flags in bug 716403 properly as well.

Comment 4

[Aaron Train [:aaronmt]]

(In reply to Chris Lord [:cwiiis] from comment #2)
> Comment on attachment 744168 [details] [diff] [review]
> Disable dynamic toolbar via prefs
> 
> [Approval Request Comment]

(In reply to Alex Keybl [:akeybl] from comment #3)
> Given the number of tracked bugs, this makes sense to me. Please make sure
> to mark the status flags in bug 716403 properly as well.

Missed a +

Comment 5

[Chris Lord [:cwiiis]]

Did you mean to a+?

Comment 6

[Chris Lord [:cwiiis]]

Argh, thought I'd pushed this ages ago...

https://hg.mozilla.org/releases/mozilla-aurora/rev/c8171498a265

Comment 7

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
-build: Firefox for Android 22.0a2(2013-05-13)
-device: Samsung Galaxy Nexus
-OS: Android 4.1.1