869368 - Flash elements are not correctly displayed and positioned in page on Gingerbread devices

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Plugins, defect)

Description

[Adrian Tamas (:AdrianT)]

Attachment: screenshot

Nightly 23.0a1 2013-05-06
Samsung Galaxy R (Android 2.3.4)/ HTC Desire Z  (Android 2.3.3)

Steps to reproduce:
1) Go to http://people.mozilla.org/~mwargers/tests/flash/flashembed.html and wait for the page to load
2) Activate the flash plugin if needed

Expected results:
The 2 flash elements are correctly displayed

Actual results:
The 2 flash elements are detached from there placeholder positions

Notes:
This is not reproducible on Honeycomb, ICS or JB

Comment 1

[Aaron Train [:aaronmt]]

Can you find a regression-window?

Comment 2

[Teodora Vermesan (:TeoVermesan)]

The regression window for this issue is the same as Bug 869366:
1. mozilla central
good build: 24.04.2013 
bad build:  25.04.2013 

pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fef5f202b2dc&tochange=690b5e0f6562

2. inbound
good build: 1366820270
bad build:  1366820510

pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a4fc2d70eade&tochange=450bbfd48532

This seems to have been caused by bug 549697.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

I'd really love to get a one changeset regression window. Kevin said he can do that, so thank you Kevin.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

David, sounds like you caused this regression.

Comment 5

[bhavana bajaj [:bajaj]]

Do we know real world websites that are impacted for us to track for future release given we shipped this regression in Fx23 ?

Comment 6

[Adrian Tamas (:AdrianT)]

This affects any website that has flash content on it. There are no top sites I can think of that use flash but any website I find with flash content experiences this problem(for e.g www.zign.com.br - the top part of the website is cut-off).

Comment 7

[bhavana bajaj [:bajaj]]

Will consider a low risk uplift when ready but no need to track given none of the top-sites are known to be impacted.Aaron feel feel to renom in case this was nominated based on the user feedback that we may have got for Fx23 or if I am misunderstanding the impact here.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

David, why does this depend on bug 833977? Do you have a plan for how to resolve this?

Comment 9

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

My understanding is this bug only applies to gingerbread devices. I don't have a gingerbread device, so I was trying to use the emulator. Unfortunately, the emulator doesn't work (bug 833977). My current plan is to put gingerbread on an unagi. I've had little success with this so far. If someone has a gingerbread device they can loan me for a bit, that would speed things up.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

David, where are you located? Can you ping me on irc so we can find you a device?

Comment 11

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #10)
> David, where are you located? Can you ping me on irc so we can find you a
> device?

I'm in Portland. I didn't see you on irc today. Feel free to email me or ping me on irc tomorrow.

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

Erin, can you get him a 2.3 device?

Comment 13

[Erin Lancaster [:elan]]

Will this device suffice? I have one here in MV: http://www.gsmarena.com/sony_ericsson_xperia_play-3608.php and will ship it out today to the Portland office, if so.

Comment 14

[Brad Lassey [:blassey] (use needinfo?)]

Talked to Erin on IRC. The Xperia play is certainly a unique device, so she's just going to make sure it reproduces before shipping it out.

Comment 15

[Erin Lancaster [:elan]]

Attachment: xperia2.3.3.png

Comment 16

[Erin Lancaster [:elan]]

Doesn't look like it repros, let me see what other GB device I can drum up, I may need kbrosnan's help to simply send loaner a phone...

Comment 17

[Erin Lancaster [:elan]]

Attachment: xperia2.3.3-true.png

Ok, it does repro once you actually tap. I didn't get proper str on that first round. yay. sending to portland today.

Comment 18

[Kevin Brosnan [Ex-Mozilla]]

Yes you need to either have Flash set to always play or tap the box to enable flash for that page.

Comment 19

[Erin Lancaster [:elan]]

FedEx Tracking number for :Keeler: 562632717010

Comment 20

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

As far as I can tell, the regression is in changeset 684a5ca2efb7, pointing to bug 858969, not bug 549697.

Comment 21

[Brad Lassey [:blassey] (use needinfo?)]

Over to Chris then

Comment 22

[Aaron Train [:aaronmt]]

I take it this isn't being worked on for 26.

Comment 23

[Chris Lord [:cwiiis]]

Argh, so it turns out the only gingerbread device I have is armv6 and Flash isn't available there... Are there any developers with such a device? (armv7, gingerbread) I could likely point out what bits of code need fiddling with, but I have no way to test atm.

Comment 24

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Fix Flash plugin positioning on Android 2.3

Comment 25

[Chris Lord [:cwiiis]]

Comment on attachment 8349489 [details] [diff] [review]
Fix Flash plugin positioning on Android 2.3

Review of attachment 8349489 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me :) I'd be careful to test that this works when you've pinch-zoomed too, but I'll assume you've done that.

Comment 26

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eac0c33eeebe

Comment 27

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/eac0c33eeebe

Comment 28

[Ioana Chiorean]

I can still see this on Fx 26 Beta 4. Will we uplift it?

I can confirm this is verified fixed using Nightly 29.0a1 (2014-01-08) on HTC Desire HD (Android 2.3.1) with the page:
http://hybridmind.com/tutorials/simple-as3-viewport-tutorial/ (http://goo.gl/iNAJT)

Comment 29

[Ioana Chiorean]

(In reply to Ioana Chiorean from comment #28)
> I can still see this on Fx 26 Beta 4. Will we uplift it?
Of course I mean Fx 27 Beta 4 :)

Comment 30

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8349489 [details] [diff] [review]
Fix Flash plugin positioning on Android 2.3

[Approval Request Comment]
Bug caused by (feature/regressing bug #): ?
User impact if declined: Busted Flash positioning on 2.2/2.3
Testing completed (on m-c, etc.): m-c, aurora
Risk to taking this patch (and alternatives if risky): None
String or IDL/UUID changes made by this patch: None

Comment 31

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8349489 [details] [diff] [review]
Fix Flash plugin positioning on Android 2.3

will approve since we're early in Beta

Comment 32

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a1e4675ef680

Comment 33

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/a1e4675ef680

Comment 34

[Paul Feher]

Verified on:
HTC Desire HD (Android 2.3.5)
Firefox 28.0b2(2014-02-10)