872122 - nsDOMCameraManager::GetListOfCameras uses a bogus static variable

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

In particular, every time you call the function, the extra cameras move further back in the array.

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

We won't hit this code path on the hardware we're using, but this is a pretty messy bug that should be fixed. The fix is relatively simple too.

Comment 2

[Boris Zbarsky [:bzbarsky]]

While we're here, could we drop the manual JSAPI and just produce XPCOM strings and let XPConnect handle all the JS bits?

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Boris Zbarsky (:bz) from comment #2)
>
> While we're here, could we drop the manual JSAPI and just produce XPCOM
> strings and let XPConnect handle all the JS bits?

That will be part of my patch.

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: clean up getListOfCameras()

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 749550 [details] [diff] [review]
clean up getListOfCameras()

r=me

Comment 6

[Mike Habicher [:mikeh] (high bugzilla latency)]

https://tbpl.mozilla.org/?tree=Try&rev=c40aa545946c

Comment 7

[Mike Habicher [:mikeh] (high bugzilla latency)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c89df3149de

Comment 8

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: clean up getListOfCameras(), r=bz

Includes the change to the fallback stub implementation; carrying r+ forward.

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 750442 [details] [diff] [review]
clean up getListOfCameras(), r=bz

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 872122
User impact if declined: if hardware implements non-{back, front} cameras, ID strings returned will erroneously increase on each call
Testing completed: tested on hamachi, emulator
Risk to taking this patch (and alternatives if risky): minimal
String or UUID changes made by this patch: nsIDOMCameraManager UUID change, although the API hasn't changed from the perspective of JS

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2c89df3149de

Comment 11

[Wayne Chang [:wchang]]

Triage - per comment 2, not directly required for the current hardware but nice to be fixed, tracking.

Comment 12

[Alex Keybl [:akeybl]]

Comment on attachment 750442 [details] [diff] [review]
clean up getListOfCameras(), r=bz

Approving in support of the emulator.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

This needs a branch-specific patch for uplift to b2g18.

Comment 14

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: clean up getListOfCameras(), r=bz, a=mozilla-b2g18+

ni?(RyanVM) - here's the b2g18 port of the patch.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/a8fcdc36236c

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

We need this on the hd branch for front-facing camera - please uplift to hd branch.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Already on v1.1hd.
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/a8fcdc36236c

Comment 18

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to [e-mail] [:lsblakk] from comment #16)
>
> We need this on the hd branch for front-facing camera - please uplift to hd
> branch.

Was this intended for bug 883084?