87637 - Advanced property editor "jiggles" changing tabs

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect, P4)

Description

[[e-mail]]

Using Build ID: 2001062104

Steps to reproduce problem:
1. Open an advancaed property editor e.g. via page colours and background
2. Click the Inline Style tab
3. Click the Javascript Events tab

Some of the dialog "jiggles" when carrying out steps 2 and 3.

Also I think that the Value field is vertically stretched when it shouldn't be.

Comment 1

[Charles Manske]

The reason is because the Styles tab has two textfields for "Name" and "Value"
while the other tabs use editable menulists.
The "value" field is stretched on purpose so its height matches matches the 
"name" editable menulist.
Its difficult to avoid the jitter without forcing the editfields in style panel
to be taller (via CSS). I don't think its really necessary to do that.
We will be developing separate CSS editing
UI soon, so that tab panel will go away when that UI is implemented.
I'm inclined to mark this "wontfix"

Comment 2

[Syd Logan]

spam composer change

Comment 3

[TucsonTester2]

One thing to note is that in the classic skin the window does not jiggle.  The
only elements that may change position and resize slightly are the attributes
(one is a drop-down, the other is a text area) and property text area at the
bottom of the window.  I saw this on Mac OS X using the 20011003 build.

Comment 4

[Charles Manske]

I believe bug 67333 is related to this kind of problem. Grid code has been 
rewritten to fix that, so this should be tested again to see if it's still a
problem.

Comment 5

[Charles Manske]

Attachment: Fix.

With this fix, all of the menulists and edit fields at the bottom are aligned
at their tops, so they all should appear in exactly the same place. 
Menulists seem to be 1px lower than textboxes; looking into that problem 
separately.

Comment 6

[Charles Manske]

Comment on attachment 63895 [details] [diff] [review]
Fix.

r=akkana

Comment 7

[Charles Manske]

Attachment: This fixes the relative vertical placement of menulists vs. textbox and other widgets

Comment 8

[Charles Manske]

Attachment: The correct patch to fix menulist margin

Comment 9

[Charles Manske]

Comment on attachment 64074 [details] [diff] [review]
The correct patch to fix menulist margin

r=akkana

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 63895 [details] [diff] [review]
Fix.

sr=[e-mail]

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 64074 [details] [diff] [review]
The correct patch to fix menulist margin

sr=[e-mail]

Comment 12

[Charles Manske]

checked in

Comment 13

[Charles Manske]

*** Bug 118431 has been marked as a duplicate of this bug. ***

Comment 14

[sujay]

Neil,  does this work for you now?

Comment 15

[[e-mail]]

Yup. Sorry for not spotting this earlier.