879152 - B2G MMS: Set the delivery status to error when retrieveMMS fail.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

We need to set the delivery status to error when retrieveMMS fail. It will cause we can't manually retrieve in second time.

Comment 1

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.0

Comment 2

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

This should be a leo+ bug. It will cause we can't manually retrieve MMS in second time.

Comment 3

[Gene Lian (I already quit Mozilla)]

Comment on attachment 757836 [details] [diff] [review]
Patch v1.0

Review of attachment 757836 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/src/ril/MmsService.js
@@ +1525,5 @@
>        // For X-Mms-Report-Allowed
>        let wish = aMessageRecord.headers["x-mms-delivery-report"];
>        let responseNotify = function responseNotify(mmsStatus, retrievedMsg) {
>          // If the mmsStatus is still MMS_PDU_STATUS_DEFERRED after retry,
>          // we should not store it into database.

// If the mmsStatus is still MMS_PDU_STATUS_DEFERRED after retry,
// we should not store it into database and update its delivery
// status to 'error'.

@@ +1529,5 @@
>          // we should not store it into database.
>          if (MMS.MMS_PDU_STATUS_RETRIEVED !== mmsStatus) {
>            if (DEBUG) debug("RetrieveMessage fail after retry.");
>            aRequest.notifyGetMessageFailed(Ci.nsIMobileMessageCallback.INTERNAL_ERROR);
> +          // Retrieved fail after retry, so we update the delivery status in DB.

We don't need this comment and please merge into the above-mentioned.

@@ +1534,5 @@
> +          gMobileMessageDatabaseService.setMessageDelivery(aMessageId,
> +                                                           null,
> +                                                           null,
> +                                                           DELIVERY_STATUS_ERROR,
> +                                                           null);

This is good but not right. Please put aRequest.notifyGetMessageFailed(...) in the callback of .setMessageDelivery(...).

Comment 4

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.1

Comment 5

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/beca3bdbc023

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/beca3bdbc023

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/96cc0e2b19a1

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/96cc0e2b19a1