87960 - leaks searching messages

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[dprice (gone)]

set XPCOM_MEM_LEAK_LOG=filename
start mozilla -mail
read messages in a newsgroup
open search mail/news messages
subject contains "foo"
search 
exit

check out the leak log.  It indicates we've leaked about 850K

for this test I used a mail profile with a news server, news.mozilla.org, I read
messages in n.p.m.porkjockeys

Comment 1

[dprice (gone)]

Attachment: a leak log for your enjoyment

Comment 2

[dprice (gone)]

-> putterman

I'm available to help/answer questions.

Comment 3

[scottputterman]

reassigning to naving

Comment 4

[chris hofmann]

boy it would be good if we could nail some of this mail leaks in the next week.

Comment 5

[Håkan Waara]

Jesus christ, 850k is huge. I agree that it would be great if this was high
priority. (BTW, isn't this a topmlk?)

Comment 6

[Navin Gupta]

Attachment: proposed fix

Comment 7

[Navin Gupta]

Ok, so have a fix for this leak. The problem was that scopeTerm was holding 
a strong reference to msgSearchSession so SearchSession was not being free'd
I will attach the leak log after the fix. 

Comment 8

[Navin Gupta]

Attachment: leak log after the fix

Comment 9

[Navin Gupta]

david, please review. 

Comment 10

[David :Bienvenu]

r=bienvenu - please don't forget to get an sr before checking in.

Comment 11

[(not reading, please use [e-mail] instead)]

sr=sspitzer, make sure to test well.

Comment 12

[Navin Gupta]

fix checked in. 

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

Attachment: My leaklog, note no nsMsgSearchSession

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED using build 2001-08-15-04 on Windows 2000, using the same
criteria as above.  Note: news search still leaks, just in other places (already
filed).