881345 - move SHARED_LIBRARY, SHORT_LIBNAME, SHARED_LIBRARY_NAME[, ...] to moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Joey Armstrong [:joey]]

Need to stop using clone on bugs, adds stray deps.

Comment 2

[Joey Armstrong [:joey]]

SHARED_LIBRARY use has wanted in Makefile.in.  Also convert values SHARED_LIBRARY is derived from - SHORT_LIBNAME, SHARED_LIBRARY_NAME, etc.

% find . \( -name '.hg' \) -prune -o -type f -print0 | xargs -0 grep SHORT_LIBNAME
./js/src/config/rules.mk:ifdef SHORT_LIBNAME
./js/src/config/rules.mk:SHARED_LIBRARY_NAME	:= $(SHORT_LIBNAME)
./js/src/config/rules.mk:  SHORT_LIBNAME \
./js/src/config/config.mk: SHORT_LIBNAME \
./js/src/config/config.mk:ifneq ($(SHORT_LIBNAME),)
./js/src/config/config.mk:$(error SHORT_LIBNAME is $(SHORT_LIBNAME) but SHORT_LIBNAME is not compatable with LIBXUL_LIBRARY)
./extensions/gnomevfs/Makefile.in:SHORT_LIBNAME	= nkgnomevfs
./extensions/widgetutils/src/Makefile.in:SHORT_LIBNAME = widgetutils
./config/rules.mk:ifdef SHORT_LIBNAME
./config/rules.mk:SHARED_LIBRARY_NAME	:= $(SHORT_LIBNAME)
./config/rules.mk:  SHORT_LIBNAME \
./config/config.mk: SHORT_LIBNAME \
./config/config.mk:ifneq ($(SHORT_LIBNAME),)
./config/config.mk:$(error SHORT_LIBNAME is $(SHORT_LIBNAME) but SHORT_LIBNAME is not compatable with LIBXUL_LIBRARY)
./db/sqlite3/src/Makefile.in:SHORT_LIBNAME    = mozsqlt3
./xpcom/sample/Makefile.in:# On OS/2, SHORT_LIBNAME is used to generate a library with an 8.3 filename,
./xpcom/sample/Makefile.in:SHORT_LIBNAME	= xpcomsmp
./xulrunner/examples/simple/components/src/Makefile.in:SHORT_LIBNAME = simpltst
./toolkit/components/ctypes/tests/Makefile.in:SHORT_LIBNAME = jscttest
./media/libsoundtouch/src/Makefile.in:SHORT_LIBNAME = soundt
./browser/components/build/Makefile.in:SHORT_LIBNAME = brwsrcmp

Comment 3

[(not currently active) Ted Mielczarek]

SHORT_LIBNAME can die, that was only necessary for OS/2 support. 

I think the only place we're using SHARED_LIBRARY_NAME is to link the gtest library:
http://mxr.mozilla.org/mozilla-central/source/toolkit/library/Makefile.in#697

so we should just figure out a different way to support that and not add that variable for one makefile.

Comment 4

[Joey Armstrong [:joey]]

(In reply to Joey Armstrong [:joey] from comment #2)
> SHARED_LIBRARY use has wanted in Makefile.in.

waned not wanted...

Comment 5

[(not currently active) Ted Mielczarek]

This looks fixed:
https://dxr.mozilla.org/mozilla-central/search?q=SHARED_LIBRARY+path%3AMakefile.in&redirect=true&case=false
https://dxr.mozilla.org/mozilla-central/search?q=SHARED_LIBRARY_+path%3AMakefile.in&redirect=false&case=false