Closed
Bug 881416
Opened 13 years ago
Closed 13 years ago
SimplePush: Shutdown connections when in offline mode.
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: nsm, Assigned: nsm)
References
Details
Attachments
(1 file)
|
4.54 KB,
patch
|
nsm
:
review+
mayhemer
:
review+
|
Details | Diff | Splinter Review |
PushService monitors for network connection changes and tries to reconnect. When in offline mode PushService should shut down rather than repeatedly trying to reconnect.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #760540 -
Flags: review?(nsm.nikhil)
Attachment #760540 -
Flags: review?(honzab.moz)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 760540 [details] [diff] [review]
Watch for offline status change
Review of attachment 760540 [details] [diff] [review]:
-----------------------------------------------------------------
Carrying forward r=jlebar from bug 867913
Attachment #760540 -
Flags: review?(nsm.nikhil) → review+
|
||
Comment 3•13 years ago
|
||
Comment on attachment 760540 [details] [diff] [review]
Watch for offline status change
Review of attachment 760540 [details] [diff] [review]:
-----------------------------------------------------------------
r=honzab
Just let you know that offline state automatic tracking is turned off on all desktop platforms from various reasons.
Attachment #760540 -
Flags: review?(honzab.moz) → review+
|
||
Updated•13 years ago
|
Component: DOM → DOM: Device Interfaces
|
|
Assignee | |
Comment 4•13 years ago
|
||
(In reply to Honza Bambas (:mayhemer) from comment #3)
> Comment on attachment 760540 [details] [diff] [review]
> Watch for offline status change
>
> Review of attachment 760540 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> r=honzab
>
> Just let you know that offline state automatic tracking is turned off on all
> desktop platforms from various reasons.
By offline state tracking, do you mean using OS services to monitor actual network connection?
|
|
||
Comment 5•13 years ago
|
||
(In reply to Nikhil Marathe from comment #4)
> By offline state tracking, do you mean using OS services to monitor actual
> network connection?
Yes, a monitor checking for availability of a live connection or interface (e.g. on windows it monitors whether at least one NIC has been assigned an IP).
|
|
Assignee | |
Comment 6•13 years ago
|
||
|
|
||
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•