Closed
Bug 881539
Opened 13 years ago
Closed 13 years ago
[camera] buttons in filmstrip preview mode are white-on-white
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(blocking-b2g:leo+, b2g18 verified, b2g-v1.1hd fixed)
RESOLVED
FIXED
| blocking-b2g | leo+ |
People
(Reporter: djf, Assigned: mshiao)
Details
(Keywords: regression)
Attachments
(2 files)
screenshot of ugly buttons
Take a picture with the camera, and the tap on the icon in the filmstrip: you'll see buttons with white icons over a white background. Clearly some sort of recent CSS regression. I'm guessing caused by the patch a few weeks ago that took away the background-color:black declaration on the body element.
|
Reporter | |
Comment 1•13 years ago
|
||
I'm nominating this for leo because I expect the fix to be trivial and because the visual effect is *so* ugly
blocking-b2g: --- → leo?
Keywords: regression
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → mshiao
|
|
||
Updated•13 years ago
|
blocking-b2g: leo? → leo+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Hi David,
Can you please review? Changed the button backgrounds to transparent since the parent element already has a defined background color.
Thanks,
Mark
Attachment #762467 -
Flags: review?(dflanagan)
|
|
Reporter | |
Comment 3•13 years ago
|
||
Comment on attachment 762467 [details]
link to pull request
Looks good.
r=djf for github commit f94203b
Attachment #762467 -
Flags: review?(dflanagan) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
landed on master commit #c2dc260db50edc82237d7a35d8bb65a8a5d02faa
https://github.com/mozilla-b2g/gaia/commit/c2dc260db50edc82237d7a35d8bb65a8a5d02faa
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•13 years ago
|
||
Uplifted c2dc260db50edc82237d7a35d8bb65a8a5d02faa to:
v1-train: 9d1151ebd17a0089f10f425659f74dac4e1e0335
status-b2g18:
--- → fixed
|
|
||
Comment 6•13 years ago
|
||
1.1hd: 9d1151ebd17a0089f10f425659f74dac4e1e0335
status-b2g-v1.1hd:
--- → fixed
|
|
||
Updated•13 years ago
|
Flags: in-moztrap?
|
|
||
Updated•13 years ago
|
Flags: in-moztrap? → in-moztrap+
|
|
||
Comment 7•13 years ago
|
||
Added Camera Suite Test Case #8743 - [Camera] The toolbar is displayed correctly while viewing photos in the Camera's filmstrip preview
Issue no longer reproduces in the Leo.
Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.158
buttons in filmstrip preview mode are not shown white-on-white.
You need to log in
before you can comment on or make changes to this bug.
Description
•