88593 - Ctrl+select on thread button only selects top message

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Peter Davis]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.1+) Gecko/20010630
BuildID:    2001063006

When you click on the "thread" icon next to a threaded email message, normally
the entire thread is expanded and selected.  But if you have another message
selected and control-click to also select the entire thread, only the first
message in the thread is selected, which is counter-intuative.  If I wanted to
only select the top message, I would click on the message name instead of the
thread button (which works).

Reproducible: Always
Steps to Reproduce:
1. Select a single message.
2. Hold down CTRL and click on the thread icon to the left of a threaded message.


Actual Results:  Only the first message of the thread is selected (in addition
to the single message in step 1).

Expected Results:  All of the messages in the thread should be selected, in
addition to other previously selected messages.

This isn't a show stopper or anything, but it is slightly annoying when I have
to go and shift-select the entire thread.

Comment 1

[Asa Dotzler [:asa]]

confirmed with 090904 mozilla win32 branch build on win2k.

jglick, is this as designed? is there a message selection spec?

Comment 2

[jglick]

This isn't currently spec'd anywhere, but I would agree with the author. What he 
describes is the desired behavior.

Comment 3

[Tuukka Tolvanen (sp3000)]

*** Bug 109508 has been marked as a duplicate of this bug. ***

Comment 4

[laurel]

*** Bug 136329 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Cowperthwaite]

*** Bug 110318 has been marked as a duplicate of this bug. ***

Comment 6

[[e-mail]]

Attachment: Proposed patch

Comment 7

[[e-mail]]

Comment on attachment 148423 [details] [diff] [review]
Proposed patch

Suggestions for alternate reviewers welcomed, what with multiple identities and
pop aggregation they've got enough to do.

Comment 8

[David :Bienvenu]

Comment on attachment 148423 [details] [diff] [review]
Proposed patch

cool, I've always wanted this.

Comment 9

[[e-mail]]

Fix checked in.

Comment 10

[u69748]

Good Job!

But, it is nice if we can toggle between select and dissellect.

Comment 11

[Matthijs Wensveen]

Ctrl+select on thread does select the thread correctly, but doesn't deselect the
thread when clicked again.
I want to be able to select every mail/thread with Ctrl-A and then deselect a
few threads.
Should I file a new bug for this?

Comment 12

[Mike Cowperthwaite]

*** Bug 251813 has been marked as a duplicate of this bug. ***