Closed Bug 886689 Opened 11 years ago Closed 11 years ago

Don't use OS_TEST == arm since some environments are set as armv7 etc

Categories

(Core :: Graphics, defect)

ARM
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

This is regression by bug 864774.

After bug 864775, if target is armv7a-unknown-linux-gnueabi, build break occurs.  Use OS_ARCH is "==" operator.

Also, ASFILES in gfx/ycbcr/Makefile.in can move to moz.build.
Attached patch fixSplinter Review
regression by bug 864774.

Use CPU_ARCH instead of OS_TEST since CPU_ARCH is normalization value of OS_TEST.  (OS_TEST can be armv7a etc).

Also, ASFILES can move to moz.build.
Attachment #767052 - Flags: review?(gps)
Depends on: 864774
Comment on attachment 767052 [details] [diff] [review]
fix

Review of attachment 767052 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #767052 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/56c9a18a4760
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
See Also: → 869135
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: