88901 - Ill formed code in MozillDocument.cpp in Document::createAttributeNS

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[David Bradley]

Encountered the following warning:

d:\cvsroot\mozilla\extensions\transformiix\source\xml\dom\mozImpl\MozillaDocument.cpp(280)
: warning C4806: '&' : unsafe operation: no value of type 'bool' promoted to
type 'const unsigned int' can equal the given constant

This is caused by the test to NS_OK within NS_SUCCEEDED macro. I think it
shouldn't be comparing to NS_OK, or it shouldn't be using the macro. One or the
other but not both.

 Attr* Document::createAttributeNS(const String& aNamespaceURI,
273 const String& aName)
274 {
275     NSI_FROM_TX_NULL_CHECK(Document)
276     nsCOMPtr<nsIDOMAttr> attr;
277 
278     if (NS_SUCCEEDED(nsDocument->CreateAttributeNS(
279                  aNamespaceURI.getConstNSString(), aName.getConstNSString(),
280                  getter_AddRefs(attr)) == NS_OK))
281         return createAttribute(attr);
282     else
283         return NULL;
284 }

Comment 1

[Fabian Guisset]

-> XSLT

Comment 2

[Fabian Guisset]

reassigning sorry

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

yep, the | == NS_OK| should go. --> peterv

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: Fix

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

r=sicking

Comment 6

[Scott Collins]

sr=scc

Comment 7

[Peter Van der Beken [:peterv]]

Checked in. Thanks all.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

it's in