89090 - clean up nsMsgAttachmentHandler.cpp, fix GenerateFileNameFromURI() to use NS_MsgHashIfNecessary()

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[(not reading, please use [e-mail] instead)]

here's the code as it stands now:

  tempName = GenerateFileNameFromURI(mURL); // Make it a sane name
#ifdef XP_WIN
  if (tempName && PL_strchr(tempName, '|'))
  {
    PR_Free(tempName);
    tempName = nsnull;
  }
#endif
#ifdef XP_MAC
  if (tempName && PL_strlen(tempName) >= 31)
    PR_DELETE(tempName)
#endif

basically, you are hacking it so if GenerateFileNameFromURI() doesn't generate 
a sane name, you throw it away and use "nsmail-X.tmp".

my issue with the code is it isn't XP (what about OS/2?)  about about other 
characters?

instead of tacking on changes using #ifdef XP_foo, you should fix 
GenerateFileNameFromURI() to really generate a "sane name"

I'd fix GenerateFileNameFromURI() to use NS_MsgHashIfNecessary(), which is how 
we've been turning a given string into something safe for the underlying OS.

it will take care of long file names and file names with illegal chars.

Comment 1

[nhottanscp]

Let me reassign to ducarroz, this is a generic mail compose code.

Comment 2

[Sheela Ravindran]

reassign based on bug summary

Comment 3

[Jean-Francois Ducarroz]

this problem should goes away once bug 86089 get fixed.

Comment 4

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Fix was checked in this morning, verified that it made it (had to repull it,
myself).

I think this is LXR-verifiable, if not, please do re-open.