Closed Bug 89143 Opened 23 years ago Closed 20 years ago

make Customize sidebar dialog accessible

Categories

(SeaMonkey :: Sidebar, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Future

People

(Reporter: aaronlev, Assigned: doronr)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: DUPEME [ADT3])

Attachments

(2 files, 1 obsolete file)

The best way is probably to use Accesskeys to underline the first letters
_Available Tabs 
_Tabs in My Sidebar

The user can then type Alt+A or Alt+T to access those panes.
Depends on: Accesskey-XUL
Keywords: access
Blocks: 89148
mpt has expressed that access keys should not be in tabs. ctrl-tab should be 
used instead.
Whiteboard: [objection-mpt]
These aren't tabs - they're the headers above panes.
new spec, will let mpt and aaron sign off first
A_vailable Tabs
_Tabs in ...
_Up
_Down
_Add
_Remove
_Preview
_Customize Tab...
_Remove
_Find more tabs.
[aaron seemed ok w/ this on irc, but ...]
Summary: Need way to switch panes in Customize sidebar screen → make Customize sidebar dialog accessible
Whiteboard: [objection-mpt] → DUPEME
sidebar accesskeys
Assignee: matt → sgehani
Priority: -- → P2
Target Milestone: --- → mozilla0.9.7
Moving to mozilla0.9.8.
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Keywords: nsbeta1+
Spilling over to mozilla1.0.
Target Milestone: mozilla0.9.9 → mozilla1.0
Reassigning 'several bugs at once' to Steve Morse, to level the load better
across the team.
Assignee: sgehani → morse
ADT3 per ADT triage team
Whiteboard: DUPEME → DUPEME [ADT3]
Mass moving nsbeta1+/adt3 bugs assigned to Navigator team engineers out to
target milestone 1.0.1.  Please confine your attentions to driving down our list
of TM 1.0 bugs for beta.  Better to help, debug, or test one of them than fix
one of these.
Target Milestone: mozilla1.0 → mozilla1.0.1
Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email adt@netscape.com.  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.
Keywords: nsbeta1-
Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email adt@netscape.com.  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.
Keywords: nsbeta1+
Target Milestone: mozilla1.0.1 → mozilla1.1alpha
reassign to component owner
Assignee: morse → sgehani
retargeting
Target Milestone: mozilla1.1alpha → Future
-> moi
Assignee: samir_bugzilla → doronr
Attached patch patch (obsolete) — Splinter Review
Attachment #147632 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 147632 [details] [diff] [review]
patch

>-      <label value="&sidebar.customize.additional.label;" crop="right"/>
>+      <label accesskey="&sidebar.customize.additional.acesskey;" control="other-panels" value="&sidebar.customize.additional.label;" crop="right"/>
Most of your changes seem to have spelling, wrapping and/or indentation errors.
Please wrap everything to 80 columns and spell accesskey with two "c"s e.g.
<label control="other-panels" value="&sidebar.customize.additional.label;"
       crop="right" accesskey="&sidebar.customize.additional.accesskey;"/>

> <!ENTITY sidebar.customize.current.label        "Tabs in &sidebarName;:">
>+<!ENTITY sidebar.customize.current.acesskey     "t">

> <!ENTITY sidebar.customize.additional.label     "Available Tabs:">
>+<!ENTITY sidebar.customize.additional.acesskey  "v">
Hmm... personally my preference would be for S and T instead... aaron?
Attachment #147632 - Attachment is obsolete: true
Attachment #148216 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 148216 [details] [diff] [review]
fix the spelling and spacing issues.

I see you fixed the wrapping the lazy way :-P
Attachment #148216 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #147632 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #148216 - Flags: superreview?(jag)
Comment on attachment 148216 [details] [diff] [review]
fix the spelling and spacing issues.

To whoever checks this in: I'd _really_ appreciate it if you could change the
indentation style of this file to have attributes on wrapped lines align with
the first attribute, as such:

<foo attr1="val1"
     attr2="val2"
     attr3="val3"/>

It'll make this file a lot more scannable if not readable. This is not a
condition for my sr though.

sr=jag
Attachment #148216 - Flags: superreview?(jag) → superreview+
checked in. finally.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: