89143 - make Customize sidebar dialog accessible

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect, P2)

Description

[Aaron Leventhal]

The best way is probably to use Accesskeys to underline the first letters
_Available Tabs 
_Tabs in My Sidebar

The user can then type Alt+A or Alt+T to access those panes.

Comment 1

[timeless]

mpt has expressed that access keys should not be in tabs. ctrl-tab should be 
used instead.

Comment 2

[Aaron Leventhal]

These aren't tabs - they're the headers above panes.

Comment 3

[timeless]

new spec, will let mpt and aaron sign off first
A_vailable Tabs
_Tabs in ...
_Up
_Down
_Add
_Remove
_Preview
_Customize Tab...
_Remove
_Find more tabs.
[aaron seemed ok w/ this on irc, but ...]

Comment 4

[matt]

sidebar accesskeys

Comment 5

[Samir Gehani]

Moving to mozilla0.9.8.

Comment 6

[Samir Gehani]

Spilling over to mozilla1.0.

Comment 7

[Peter Trudelle]

Reassigning 'several bugs at once' to Steve Morse, to level the load better
across the team.

Comment 8

[Peter Trudelle]

ADT3 per ADT triage team

Comment 9

[Peter Trudelle]

Mass moving nsbeta1+/adt3 bugs assigned to Navigator team engineers out to
target milestone 1.0.1.  Please confine your attentions to driving down our list
of TM 1.0 bugs for beta.  Better to help, debug, or test one of them than fix
one of these.

Comment 10

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 11

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 12

[Stephen P. Morse]

reassign to component owner

Comment 13

[Vedran Miletic]

retargeting

Comment 14

[Doron Rosenberg (IBM)]

-> moi

Comment 15

[Doron Rosenberg (IBM)]

Attachment: patch

Comment 16

[[e-mail]]

Comment on attachment 147632 [details] [diff] [review]
patch

>-      <label value="&sidebar.customize.additional.label;" crop="right"/>
>+      <label accesskey="&sidebar.customize.additional.acesskey;" control="other-panels" value="&sidebar.customize.additional.label;" crop="right"/>
Most of your changes seem to have spelling, wrapping and/or indentation errors.
Please wrap everything to 80 columns and spell accesskey with two "c"s e.g.
<label control="other-panels" value="&sidebar.customize.additional.label;"
       crop="right" accesskey="&sidebar.customize.additional.accesskey;"/>

> <!ENTITY sidebar.customize.current.label        "Tabs in &sidebarName;:">
>+<!ENTITY sidebar.customize.current.acesskey     "t">

> <!ENTITY sidebar.customize.additional.label     "Available Tabs:">
>+<!ENTITY sidebar.customize.additional.acesskey  "v">
Hmm... personally my preference would be for S and T instead... aaron?

Comment 17

[Doron Rosenberg (IBM)]

Attachment: fix the spelling and spacing issues.

Comment 18

[[e-mail]]

Comment on attachment 148216 [details] [diff] [review]
fix the spelling and spacing issues.

I see you fixed the wrapping the lazy way :-P

Comment 19

[jag (Peter Annema)]

Comment on attachment 148216 [details] [diff] [review]
fix the spelling and spacing issues.

To whoever checks this in: I'd _really_ appreciate it if you could change the
indentation style of this file to have attributes on wrapped lines align with
the first attribute, as such:

<foo attr1="val1"
     attr2="val2"
     attr3="val3"/>

It'll make this file a lot more scannable if not readable. This is not a
condition for my sr though.

sr=jag

Comment 20

[Doron Rosenberg (IBM)]

Attachment: Indenting the attributes

Comment 21

[Mike Kaply [:mkaply]]

checked in. finally.