892499 - When findbar can't find any results, there is disturbing overline over the text

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

The overline make it really hard to read the text user has just typed.

Comment 1

[Mike de Boer [:mikedeboer]]

Olli, is this on all platforms? Could you attach a screenshot for us? Thanks!

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: when text is found

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: when the text isn't found

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

This is on linux. Apparently doesn't happen on OSX. Don't know about windows

Comment 5

[Mike de Boer [:mikedeboer]]

Okay, thanks a ton! I'll check it out as soon as possible.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

This is some recent-ish regression.

Comment 7

[Tom S. (please needinfo tschuster)]

This is awful. I looked at this, but I didn't see any text-decoration: line-through. Maybe this is somehow done with borders?

Comment 8

[Andrew McCreight (out until 2026) [:mccr8]]

jlebar was seeing this, too.

Comment 9

[Justin Lebar (not reading bugmail)]

And here I thought this was intentional.  :)

Comment 10

[Mike de Boer [:mikedeboer]]

I can't reproduce this at all :( I'm running Ubuntu 13.04, 64bit. Is there another OS I should be checking to get this behavior?

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

I can reproduce it with the same setup.

> .findbar-textbox[status="notfound"] {
>   box-shadow: 0 0 0 1em #f66 inset;
>   color: white;
> }

FTR, if I change the 1em to 1.1em the issue seems gone. Not sure what that tells us.

Comment 12

[Mike de Boer [:mikedeboer]]

Dão, here - http://hg.mozilla.org/mozilla-central/diff/ce23b9b734c0/toolkit/themes/gnomestripe/global/findBar.css - you introduced the use of box-shadow to colorize the background of the text input to red/ yellow. Why did you choose that instead of background-color?

For reference: Bug 483378 from four years ago(!)

Comment 13

[Dão Gottwald [:dao]]

(13:36:24) dao: we couldn't use background-color as it wouldn't work on natively styled text fields. now we could.

Comment 14

[Mike de Boer [:mikedeboer]]

Attachment: Patch 1: use background-color instead of box-shadow to prevent drawing glitches

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 778426 [details] [diff] [review]
Patch 1: use background-color instead of box-shadow to prevent drawing glitches

Can you do this for all platforms?

Comment 16

[Mike de Boer [:mikedeboer]]

Attachment: Patch v2: use background-color instead of box-shadow to prevent drawing glitches

OSX already uses background-color, so I didn't need to change anything there.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67f117684441

Comment 18

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/67f117684441

Comment 19

[Manuela Muntean [Away]]

Verified as fixed with the latest Aurora (build ID: 20130903004001) on Ubuntu 13.04 64bit, while testing for the pre-beta sign-off of the Find Bar Redesign feature.