908015 - test_startup_(no)session_sync.js takes too long (top 8 duration)

Status: NEW

(Firefox :: Session Restore, defect)

Description

[Mihnea Dobrescu-Balaur (:mihneadb)]

This test takes too long and it affects performance when running xpcshell tests in parallel. It should be made faster or split across multiple files.

You can see the duration data here[1]. It was collected on a linux x64 laptop.


[1] http://www.mihneadb.net/xpcshelltest-resource-usage/

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Running all sessionstore tests, test_startup_session_sync.js and test_startup_nosession_sync.js seem to take 30s (is that a timeout?) to finish. Running these tests on their own finishes almost instantly. Also, I can only reproduce this on Linux, not on Mac.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

The test hangs here:

http://hg.mozilla.org/mozilla-central/file/2ab07dec6404/browser/components/sessionstore/src/_SessionFile.jsm#l201

Seems like creating the PromiseWorker takes a looooong time for whatever reason.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

This sounds somehow related to bug 845190. These two tests were disabled on Win+Linux debug runs because of "thread pool wasn't shut down" assertions.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

I removed all tests but:

[test_startup_nosession_sync.js]
[test_startup_session_async.js]

and I still see test_startup_nosession_sync.js taking a long time. If I however make test_startup_session_async.js a no-op by returning at the top of run_test(), then the *sync.js test finishes immediately. It seems like these tests shouldn't interfere but they do.