910800 - upgrade to django 1.5

Status: RESOLVED FIXED

(Input Graveyard :: Code Quality, defect, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

We need to upgrade to Django 1.5 soon. Because Input is a playdoh project, it probably means we need to upgrade playdoh first.

It might make sense to take this as an opportunity to ditch playdoh-lib.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Putting this in the 2013q3 backlog. Should do it soon.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bumping to next quarter.

Making it a P3. We don't *have* to do it, but it's a good idea.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Django 1.5 release notes:

https://docs.djangoproject.com/en/dev/releases/1.5/

Interesting bits:

> Management commands do not raise SystemExit any more when called by code from call_command. Any exception raised by the command (mostly CommandError) is propagated.
>
> Moreover, when you output errors or messages in your custom commands, you should now use self.stdout.write('message') and self.stderr.write('error') (see the note on management commands output).

> In the admin, you can now filter users by groups which they are members of.

> The new ALLOWED_HOSTS setting validates the request’s Host header and protects against host-poisoning attacks. This setting is now required whenever DEBUG is False, or else django.http.HttpRequest.get_host() will raise SuspiciousOperation. For more details see the full documentation for the new setting.

> The cleaned_data dictionary is now always present after form validation. When the form doesn’t validate, it contains only the fields that passed validation. You should test the success of the validation with the is_valid() method and not with the presence or absence of the cleaned_data attribute on the form.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Ugly. Let me try that again:

Django 1.5 release notes:

https://docs.djangoproject.com/en/dev/releases/1.5/

Interesting bits:

> Management commands do not raise SystemExit any more when called by code from call_command.
> Any exception raised by the command (mostly CommandError) is propagated.
>
> Moreover, when you output errors or messages in your custom commands, you should now use 
> self.stdout.write('message') and self.stderr.write('error') (see the note on management 
> commands output).


> In the admin, you can now filter users by groups which they are members of.


> The new ALLOWED_HOSTS setting validates the request’s Host header and protects against 
> host-poisoning attacks. This setting is now required whenever DEBUG is False, or else 
> django.http.HttpRequest.get_host() will raise SuspiciousOperation. For more details see 
> the full documentation for the new setting.

> The cleaned_data dictionary is now always present after form validation. When the form
> doesn’t validate, it contains only the fields that passed validation. You should test
> the success of the validation with the is_valid() method and not with the presence or
> absence of the cleaned_data attribute on the form.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I made some code changes that allow Fjord to work with Django 1.5.

PR: https://github.com/mozilla/fjord/pull/182

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

I did some prep work in these two commits:

* https://github.com/mozilla/fjord/commit/e13a69a
* https://github.com/mozilla/fjord/commit/77d391f

Still need to update playdoh-lib to Django 1.5 and then I can update Fjord.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

All the work I needed to do in playdoh-lib and funfactory is done.

In a PR: https://github.com/mozilla/fjord/pull/185

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in: https://github.com/mozilla/fjord/commit/f8e8a89

Pushed to production just now.

I'll spend the next hour keeping an eye on everything to make sure things are ok.