910827 - OS.File starts worker thread immediately if logging is enabled

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[:Irving Reid (No longer working on Firefox)]

When OS.File is started with preference toolkit.osfile.log = 'true', the code at https://hg.mozilla.org/mozilla-central/file/21b5af569ca2/toolkit/components/osfile/modules/osfile_async_front.jsm#l226 posts the debugging message at startup time, which causes _PromiseWorker.jsm to instantiate the ChromeWorker.

Not a huge deal, but it makes it rather difficult to use OS.File logging to determine what other code is causing the ChromeWorker to start.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

This can be a nice mentored bug for someone who already understands workers.

Comment 2

[Bruno Schneider [:Bruss]]

This could be a good first bug to start, can anyone assign this bug to me?

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Here we go. If you have any question, don't hesitate to ask (preferably on #introduction).

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Ah, it turns out that I'll need to fix this one quickly. Sorry, Bruss, I'll need to take over this bug.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: Setting OS.File DEBUG will not automatically start the OS.File thread

Here we go. This should also fix bug 845190.

Comment 6

[David Teller [:Yoric] - still alive but not very active]

(at least the test_logging.js part of that bug)

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 804872 [details] [diff] [review]
Setting OS.File DEBUG will not automatically start the OS.File thread

Review of attachment 804872 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/osfile/tests/xpcshell/xpcshell.ini
@@ -7,5 @@
>  [test_osfile_async.js]
>  [test_profiledir.js]
>  [test_logging.js]
> -# bug 845190 - thread pool wasn't shutdown assertions
> -skip-if = (os == "win" || "linux") && debug

Can you put this in a separate bug (bug 845190 seems like a good candidate!)?

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Attachment: Setting OS.File DEBUG will not automatically start the OS.File thread, v2

Same code, minus patch to xpcshell.ini.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/426c0629a3dd

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/426c0629a3dd