91310 - Align Right splits table

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[sujay]

using 7/17 branch build

1) launch netscape
2) open above attachment into composer
3) select any four cells in onw row
4) ALign Right

table splits in two.

Comment 1

[Dwayne]

*** This bug has been marked as a duplicate of 91288 ***

Comment 2

[Dwayne]

Ok just noticed some correlation here...

Sujay, did I step on your toes here?  Why did you file this a second time?  Were
you trying to distinguish something?  I think we can keep the other bug alone,
modify the OS/Platform, and update the description...do we need a separate one?

Forgive me if I'm missing something... and know that I marked it as a dup before
I realized you had put a comment in that bug.

Comment 3

[sujay]

The other bug 91288 only happens in Show All tags mode.

the bug I filed happens in normal mode.

Comment 4

[sujay]

Dwayne, lets keep this open.....they sound similar, but there are
some differences at how I arrived at the same Align-Right problem:

You might ultimately be right in the end, but I don't want something
to fall thru the cracks.

Comment 5

[sujay]

cc: brade.

Comment 6

[Dwayne]

OK, I getcha.

Here I am all paranoid cuz I *just* got some permission bits and I thought I was
making a bad move when I saw you had commented in both bugs...blegh

I understand now what you mean, and I agree.  No cracks allowed.  :)

Comment 7

[[e-mail]]

After duplicating the effect I made the mistake of hitting "Undo"...KABOOM!

So you might want to upgrade this problem to status of crash.

Comment 8

[rubydoo123]

Neil - did you get a stack trace on your crash?

Comment 9

[kinmoz]

I'll take this, I have a fix for this in my tree.

Comment 10

[kinmoz]

Attachment: Patch that fixes 91310 and 91288 (Rev 1)

Comment 11

[kinmoz]

I just attatched a patch that fixes this bug as well as 91288 which takes a 
slightly different code path through the editor.

Note that fixing these 2 bugs masks the layout crash covered by bug 91214.

The patch also fixes the problem where lists containing sublists, were split 
during alignment.

Comment 12

[Kathleen :Brade]

r=brade

Comment 13

[Marc Attinasi]

sr=attinasi

Comment 14

[kinmoz]

Fix checked into TRUNK:

   mozilla/editor/base/nsHTMLEditRules.cpp  revision 1.187

Comment 15

[kinmoz]

Really marking fixed this time. :-)

Comment 16

[James Baxter]

Verified on 8-30 Build