Closed Bug 914085 Opened 11 years ago Closed 11 years ago

Enable Promises in B2g

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:-)

Status:
RESOLVED WONTFIX
Project Flags:
blocking-b2g -

People

(Reporter: mikehenrty, Assigned: mikehenrty)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

promise.patch
854 bytes, patch
gwagner
: review+
Details | Diff | Splinter Review 
We need promises to implement Notification.get().
Assignee: nobody → mhenretty
Blocks: 899574
Depends on: 897913
Attached patch promise.patch — — Splinter Review 

        Attachment #801498 -
        Flags: review?(anygregor)

        Attachment #801498 -
        Flags: review?(anygregor) → review+
blocking-b2g: --- → koi?

    
    

    
  
No.  This is not OK.  This enables promises for all web pages on b2g, which is totally unacceptable.

We carefully set things up in bug 897913 so you would NOT have to do this.  Why are you doing it?

    
    

    
  
And why are patches like this landing without review from _anyone_ who knows anything about the module in question?  :(

    
    

    
  
https://hg.mozilla.org/integration/b2g-inbound/rev/820790024cda
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX

    
    

    
  
FWIW, this also broke a bunch of tests on B2G.
Whiteboard: [systemsfe]
blocking-b2g: koi? → ---
blocking-b2g: --- → -

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: