91679 - offline: can't download messages > 1MB for offline use

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P1)

Description

[grylchan]

Commercial Branch Builds
2001-07-20-06-0.9.2/ WinNT 4.0
2001-07-20-04-0.9.2/ linux 2.2
2001-07-20-03-0.9.2/ mac 9.0.4
And
2001-07-20-08-trunk/ linux 2.2

Messages that are approx 1MB or larger will not get downloaded. The download
process 'hangs' as you see the spinning 'barber pole' and the message
'downloading message'. I waited for 5 mins and it still had
not finished. 

Messages that are < 1mb can be downloaded. Here are couple of
random test case results:
  Message size    Did it Download?
  ============    ===============
   303 kb             y
   982 kb             y
   1037 kb            n
   1548 kb            n
   5176 kb            n

Note that since you can't set the pref "Don't download messages greater
     than 50kb" [bug 86014], when you select a folder to download,
     messages greater than 50kb will not get downloaded. I had to
     select the message or flag it and then use 'Get selected Message'
     or 'Get flagged Message' to download the message.

4.x doesn't have a problem downloading these messages. 

steps to reproduce
1.Set up imap mail account
2.send yourself a couple of different sized messages (by attaching different
  sized items to your messages)
3.Get them in your inbox
4.Select it or flag it
5.File|Offline| Get Selected Messages
                Get Flagged Messages

Result: spinning barber pole and it says you are downloading the message
        but after few minutes it is still downloading. So the message
        never gets downloaded.
Expected: to download the message in reasonable amount of time

Comment 1

[David :Bienvenu]

I was able to reproduce this, but haven't drilled down on it yet.

Comment 2

[scottputterman]

adding nsenterprise keyword

Comment 3

[David :Bienvenu]

hmm, I wonder if this has to do with the memory cache. Perhaps we're confused
about whether the message is in the memory cache.

Comment 4

[scottputterman]

adding nsenterprise+

Comment 5

[David :Bienvenu]

what seems to happen here is that the imap process stops reading the data coming
back from the server on the message fetch, I'm not sure why. The log just sort
of hangs on the message fetch, so we've stopped reading data, though I'm pretty
sure the server is still sending data.

Comment 6

[David :Bienvenu]

Attachment: proposed fix

Comment 7

[David :Bienvenu]

cc'ing Navin and Seth for review. The problem (very embarassing) was that I set
up the imap folder as a stream listener, but then was never reading from the
stream, so it got backed up and stalled. So I stopped doing that. I also had to
change the place I initialize the msg window on the url to catch the case where
there's no listener, and a couple other small changes.

Comment 8

[Navin Gupta]

r=naving

Comment 9

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 10

[David :Bienvenu]

fix checked in.

Comment 11

[grylchan]

Commercial builds:
2001-08-15-09-trunk/ - nt 4.0
2001-08-15-14-trunk- linux 2.2, mac 9.0.4

Verified you can dowload various sized messages bigger
than 1 MB. And it is readable once you are offline.
Tried different ways (dowload and sync, download now, get
selected/flagged messages).

I used test cases in my initial bug description.

Marking as verified.