9200 - Finish implementation of "Preview"/"Edit" modes.

Status: VERIFIED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[sujay]

using 7/2 build of apprunner

1) launch apprunner and editor
2) In the Ender HTLM Test Page window, click on Preview button

It should bring up that page in a browser window.

It doesn't...nothing happens

all platforms.

Comment 1

[buster]

I'm not sure we're on the hook for this in the first release.  If mail compose
doesn't need preview, it's off our list.  marking "enhancement" for now, but
I'll let simon decide if it's really in or out.

Comment 2

[Simon Fraser [no longer active]]

Do we need preview now that we're a WYSIWIG editor? I guess we might, for testing
JavaScript and stuff like this. Putting on M12.

Comment 3

[Kathleen :Brade]

We also need preview (of sorts) if users want features like "Show Paragraph
Marks" or to Hide Targets?

Comment 4

[Simon Fraser [no longer active]]

Reassign to cmanske, who did the preview button.

Comment 5

[Matthew Tuck [:CodeMachine]]

At the moment it just changes the button, so I assumed you'd actually be able to
view the preview in the same window with a reflow.  Is the old new window
behaviour what it will eventually do?

Comment 6

[Charles Manske]

No, the preview will just be a reflow in the same window after the removal of
a style sheet. What I was doing before was wrong, but I have other priorities
before revisiting this issue.
The change will be subtle: borders on table cells will appear and named anchors
(and other tags normally not displayed) will appear. It will be *much* better
than the old way!

Comment 7

[Charles Manske]

Actually, I just tested this and I *am* still "switching" style sheets by
loading either ua.css or Editor.css. It's just that there's nothing in the
test page that makes the "preview" mode look any different! (I told you the
difference would be subtle!) Proves we are now a true WYSIWIG!
Here's one way to test what mode you are in:
1. Scroll down to the sampe table.
2. Place your caret in a cell and delete the contents with delete and/or
backspace key. When all is deleted, the cell border will disappear if you are
in "Preview" mode (Navigator doesn't show borders on empty cells.)
3. When you toggle to "Edit Mode", the cell border should show up.
Right now, making tags like Named Anchors appear is dependent on a CSS bug.
I'll leave this bug open to remind me to reengineer the way the style sheets
are loaded and unloaded.

Comment 8

[Matthew Tuck [:CodeMachine]]

Quite cool.  Now I know this I submitted bug 11140.  =)

I assume most of the UI will eventually get disabled in preview mode.  Is this
blocked on something?

Comment 9

[Charles Manske]

No, I had no intention of preventing editing in the "preview" mode.
I see no reason to do so.  I can see this as being very useful: After inserting
things like Named Anchors in the "edit mode" (so you can see them), switch to
"preview" mode to do tweaking of text and table sizes, etc. and be guaranteed
to layout *exactly* as the browser will see it.

Comment 10

[Charles Manske]

Changed the summary.

Comment 11

[Matthew Tuck [:CodeMachine]]

I get it.  In that case I think the name's a little misleading, especially
having a normal mode called "Edit Mode".  I'd call the "preview" something like
"WYSIWYG" or "Exact" mode.

Does Javascript still run in this mode?  If not, there probably should still be
a full "preview".

Comment 12

[sujay]

verified in 10/12 build.