922515 - The italic text appears more sloped

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[blinky]

Steps to reproduce:

1. Disable hardware acceleration.
2. Restart Firefox.
3. Go to page, for example Arabic italic, https://dl.dropboxusercontent.com/u/95157096/85f61cf7/poz82cb7.html


Actual results:

The italic text appears more sloped with HWA disabled.

Screenshot: http://img28.imageshack.us/img28/750/1jez.png


Also happens with other languages, for example, https://dl.dropboxusercontent.com/u/95157096/85f61cf7/c53wfz58.html

Screenshot: http://img703.imageshack.us/img703/1271/eiu0.png

Comment 1

[Alice0775 White]

regression pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ff429a27230b&tochange=94a6733b01dc

Comment 2

[bhavana bajaj [:bajaj]]

Matt, can you please help here as this sounds like a regression from 907926.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Don't skew twice for cairo fonts

This is a bit gross.

I wanted to un-apply the matrix within DrawTargetCairo, but you can't modify the transform on cairo_scaled_font.

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 825043 [details] [diff] [review]
Don't skew twice for cairo fonts

Review of attachment 825043 [details] [diff] [review]:
-----------------------------------------------------------------

I guess it'll have to do.

Comment 5

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/412123f1e16a

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/412123f1e16a

Comment 7

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 825043 [details] [diff] [review]
Don't skew twice for cairo fonts

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 907926
User impact if declined: Double italic on some fonts
Testing completed (on m-c, etc.): Been on m-c for a while
Risk to taking this patch (and alternatives if risky): Very low risk.
String or IDL/UUID changes made by this patch: None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ecce583af9a8

Comment 9

[Manuela Muntean [Away]]

Verified as fixed with latest Aurora (build ID: 20131121004004) on Win 7 64-bit.

Comment 10

[Manuela Muntean [Away]]

Also verified with latest Nightly, W7 64-bit, build ID: 20131121030201