9229 - Add PRTime supports to date format interface

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P3)

Description

[nhottanscp]

// performs a locale sensitive date formatting operation on the PRTime
parameter
  NS_IMETHOD FormatPRTime(nsILocale* locale,
                          const nsDateFormatSelector  dateFormatSelector,
                          const nsTimeFormatSelector timeFormatSelector,
                          const PRTime  prTime,
                          nsString& stringOut) = 0;

  // performs a locale sensitive date formatting operation on the PRExplodedTime
parameter
  NS_IMETHOD FormatPRExplodedTime(nsILocale* locale,
                                  const nsDateFormatSelector
dateFormatSelector,
                                  const nsTimeFormatSelector timeFormatSelector,
                                  const PRExplodedTime*  explodedTime,
                                  nsString& stringOut) = 0;

Comment 1

[nhottanscp]

M9, needed by mailnews.

Comment 2

[Jean-Francois Ducarroz]

Thanks Nahoki. Until the new functions are implemented, mailnews wont use it as well the other one that use
time_t or tm for displaying the date in the message thread. Therefore the date might be always displayed in english.

Comment 3

[Katsuhiko Momoi]

Added [e-mail] & [e-mail] to the CC line.

Comment 4

[nhottanscp]

Checked in new functions but still have a bug, not ready for the use yet.

Comment 5

[nhottanscp]

Fixed by today's check in.
I tested FormatPRExplodedTime on Win32, Linux and Macintosh.
FormatPRTime is not tested but it just calls FormatPRTime (let me know for any
problem).

Comment 6

[Katsuhiko Momoi]

I didn't realize that this had been fixed as QA was assigned to nhotta.
I only have time to look at Windows-J behavior but it is working
well on NT4-J. I need to look at Win98-US/J, WinNT-US, Mac and
Unix later. Will do this after M9.
Changing QA contact to momoi.

Comment 7

[nhottanscp]

I have forgot about verifying this, sorry.
There is a testing info about this. This PRTime support has no relation with
locale. Testing date/time format in Latin1 languages (e.g. "en", "fr") should
verify this bug. In other words, non Latin1 locale may not work depends on the
testing platform (see #5561, the bug has just fixed but the client side change
is also needed).

Comment 8

[Katsuhiko Momoi]

Thanks. It seems that date/time format is working on NT4.
What I remember for M8 was that this was turned off even for NT4 and
I wrote about it for M8 Release notes. I guess I can say for M9 that
date/time formatting works for NT4? but not for Win9x or Macintosh?

Comment 9

[nhottanscp]

>I guess I can say for M9 that
>date/time formatting works for NT4?
Yes, for all (installed) locales.
>but not for Win9x or Macintosh?
and Unix, works for Latin1 locales only.

Comment 10

[Katsuhiko Momoi]

Based on prior discussions, marking the fix verified.