92437 - code clean up of pref-directory.js

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P4)

Description

[(not reading, please use [e-mail] instead)]

clean up gAvailDirectories[0][0] and gAvailDirectories[0][1] to be 
gAvailDirectories[0].name and gAvailDirectories[0].value

from bug #86442

instead of:

+        identityServer[j] = new Array(2);
+        identityServer[j][0] = ;
+        identityServer[j][1] = false;

do this:

identityServer[j] = {server:currentIdentity.directoryServer, deleted:false};

then, instead of doing identityServer[j][0], you can do identityServer[j].server
and instead of identityServer[j][1] you can do identityServer[j].deleted

it makes the code much more readable.  (I'm guess the boolean was 
for "deleted", I'll leave the name to you.)

I'd recommend the same thing for cleaning up code like this:

          directoriesList.label = gAvailDirectories[0][1];
          directoriesList.value = gAvailDirectories[0][0];

Comment 1

[Srilatha Moturi]

Attachment: patch v1

Comment 2

[Srilatha Moturi]

Attachment: updated patch

updated the patch against the latest trunk. Also fixed one js strict warning.

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 64530 [details] [diff] [review]
updated patch

looks good, sr=sspitzer

another suggestion:

change

if (gAvailDirectories.length >= 1)

to 

if (gAvailDirectories.length)

Comment 4

[racham]

r=racham

Comment 5

[Srilatha Moturi]

I made the change 
if (gAvailDirectories.length >= 1) to 
if (gAvailDirectories.length)

Fix checked in 

Comment 6

[yulian chang]

According to Srilatha, this bug has the same fix as bug 119777.

No warning in JS Console when deleting LDAP server.