92650 - directory/xpcom/public/nsLDAP.h should go away

Status: RESOLVED FIXED

(Directory :: LDAP XPCOM SDK, defect, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

The nsresult mapping stuff should move to a %C++{} block in nsILDAPErrors.idl,
and there shouldn't really be any need to expose the PR_Log stuff at all.

Comment 1

[yulian chang]

Reassign QA Contact to Olga

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Taking; I'd like to make this happen before 1.0.  It should speed up the build
very slightly, too.

Comment 3

[Mark Banner (:standard8)]

I have a patch for this.

Comment 4

[Mark Banner (:standard8)]

Attachment: Proposed patch

This is the probable patch, I need to do a clobber build first before requesting review.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 208011 [details] [diff] [review]
Proposed patch

This worked for clobber builds... requesting reviews.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 208011 [details] [diff] [review]
Proposed patch

r+sr=dmose; thanks Mark!

Comment 7

[Mark Banner (:standard8)]

Checked in patch & removed nsLDAP.h => fixed.