93240 - Installer window too narrow; License text wraps

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[John Bafford]

The license text displayed when the installer is run is formatted for at 76
columns, but the window that displays the text is only 67 columns wide.

Comment 1

[Sean Su]

reassigning to Syd.

Comment 2

[Daniel Veditz [:dveditz]]

very ugly, hopefully not too hard to fix without triggering re-formatting all
the other wizard pages.

Comment 3

[John Bafford]

Would it also be possible to get rid of the little arrow to indicate
word-wrapping? I don't see that it's really necessary, and most programs don't
do that. Although it does add some value, I don't see that it's necessary to see
the distinction between a newline and line wrapping in a web browser or for a
simple text display.

Comment 4

[Marek Z. Jeziorek]

nsbranch+ per pdt triage
is it beta or final license?
should we take this under install drop?

Comment 5

[Jaime Rodriguez, Jr.]

This looks like polish work. Is this really a stop ship?

Comment 6

[selmer (gone)]

Jaime, if it impacts a user's ability to see the license then it would open us
up to legal problems we can't afford.  Even if it's OK on US builds, the issue
still comes up on international builds.  Maybe it's not stop-ship, need to know
what happens to the user experience first.

Comment 7

[Grace Bush]

Entire license can be read, first 5 or 10 lines have arrows showing wrap. 
Window can be enlarged - slightly - shows license without arrows

Comment 8

[Jaime Rodriguez, Jr.]

Adding correctness Status Whiteboard, correct/expected behavior does not occur.

Comment 9

[selmer (gone)]

PDT-.  No patch, too late for cosmetic changes.  If you have a *strong* argument
why this should be pursued further, please add it here and remove the PDT-.

Comment 10

[Jaime Rodriguez, Jr.]

This something we would like to take for an earlier release. Can we get it in
for MachV. Nominating ...

Comment 11

[Syd Logan]

Attachment: in with word wrap and line wrap, out with the annoying arrows

only remaining thing to do would be the format the license text to get rid of
the end of line characters so it lays out better. But at least now the black
arrows are gone, and the text is all readable.

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 68285 [details] [diff] [review]
in with word wrap and line wrap, out with the annoying arrows

sr=dveditz

Comment 13

[Syd Logan]

fixed

Comment 14

[Grace Bush]

verified on 2/20 trunk build